0
0
mirror of https://gitlab.nic.cz/labs/bird.git synced 2024-11-12 14:18:43 +00:00
Commit Graph

4079 Commits

Author SHA1 Message Date
Igor Putovny
d9ef88698f Change order of parameters in a few functions 2023-10-18 12:06:27 +02:00
Igor Putovny
a7d2b780d0 Simplify delete_trie() function 2023-10-13 15:26:03 +02:00
Igor Putovny
aa611e48e0 Assign bucket of ancestor node to leaf node 2023-10-06 14:38:07 +02:00
Igor Putovny
67e6a3e351 Fix incorrect implementation of the third pass 2023-10-06 14:19:04 +02:00
Igor Putovny
b003ffd348 Assign route bucket only to the last inserted node 2023-10-06 13:52:27 +02:00
Igor Putovny
3c87d99fe4 Fix argument order in several functions 2023-10-06 13:40:49 +02:00
Igor Putovny
0abecd3002 Add a few comments, print prefixes after aggregation 2023-10-06 12:52:08 +02:00
Igor Putovny
c164515fb6 Extend remove_node() with deleting root node 2023-09-21 13:49:59 +02:00
Igor Putovny
aec8688fbc Fix aggregator_bucket_unionize()
The last two while loops were incorrectly placed inside the first while loop
2023-09-21 12:40:00 +02:00
Igor Putovny
b81e91bed6 Fix const warning, add few comments 2023-09-20 13:46:34 +02:00
Igor Putovny
4dffb687f1 Delete trie during aggregator shutdown 2023-09-20 13:05:49 +02:00
Igor Putovny
c2627f45fd Refactor and fix aggregator_bucket_unionize() 2023-09-20 12:19:01 +02:00
Igor Putovny
144e6c393c Fix aggregator_bucket_intersect(), add comments and fix naming 2023-09-19 12:06:52 +02:00
Igor Putovny
ead1ade4c2 Remove unused code 2023-09-18 14:48:22 +02:00
Igor Putovny
ce1e256874 Add new implementation of third_pass() and remove old implementation 2023-09-18 14:18:25 +02:00
Igor Putovny
812e646625 Move trie initialization to aggregator_start() 2023-09-15 11:04:37 +02:00
Igor Putovny
b48ac47aec Fix previous version, aggregator is now stable but untested 2023-09-14 09:33:14 +02:00
Igor Putovny
e94c9cbf36 Implement basics of prefix aggregation functionality 2023-09-11 12:38:19 +02:00
Maria Matejka
0a408c22f6 Aggregator: Fixed hashing of adata 2023-07-12 15:11:00 +02:00
Maria Matejka
2e8e901262 Aggregator moved to a separate protocol
Also updated data structures and reconfigure.

Known bug: the hash doesn't take adata into account. Needs fixing!
2023-07-10 13:46:09 +02:00
Maria Matejka
8ccc4d0679 Aggregator: polishing of filter API 2023-06-23 11:28:19 +02:00
Igor Putovny
e9d9dc7561 Basic route aggregation
User can specify list of route attributes in the configuration file
and run route aggregation on the export side of the pipe protocol.
Routes are sorted and for every group of equivalent routes
new route is created and exported to the routing table.
It is also possible to specify filter which will run for every
route before aggregation.
Furthermore, it will be possible to set attributes of new routes
according to attributes of the aggregated routes.

This is a work in progress.
2023-06-23 09:43:38 +02:00
Maria Matejka
d001ef83f9 Simple testing of reconfiguration to a slightly different one 2023-06-23 09:05:48 +02:00
Maria Matejka
58177b4bc9 Filter: Print instructions take only one value (simplification) 2023-06-19 17:32:19 +02:00
Maria Matejka
c0179825da Filter: Shortened method declarations 2023-06-19 17:32:19 +02:00
Maria Matejka
7b49ba1e65 Filter: The for loop uses the method system for type dispatch 2023-06-19 17:32:19 +02:00
Maria Matejka
784a92b300 Removing unused terminals from filter config 2023-06-19 17:32:19 +02:00
Maria Matejka
8751d8c447 Filter: Methods rework
Methods can now be called as x.m(y), as long as x can have its type
inferred in config time. If used as a command, it modifies the object,
if used as a value, it keeps the original object intact.

Also functions add(x,y), delete(x,y), filter(x,y) and prepend(x,y) now
spit a warning and are considered deprecated.

It's also possible to call a method on a constant, see filter/test.conf
for examples like bgp_path = +empty+.prepend(1).

Inside instruction definitions (filter/f-inst.c), a METHOD_CONSTRUCTOR()
call is added, which registers the instruction as a method for the type
of its first argument. Each type has its own method symbol table and
filter parser switches between them based on the inferred type of the
object calling the method.

Also FI_CLIST_(ADD|DELETE|FILTER) instructions have been split to allow
for this method dispatch. With type inference, it's now possible.
2023-06-19 17:32:19 +02:00
Maria Matejka
b2ae515cf8 Uninitialized filter variables of path/[el]?clist types are now explicitly empty 2023-06-17 11:54:12 +02:00
Maria Matejka
c6494e45a6 Conf: config warnings show the file position 2023-06-17 00:03:30 +02:00
Maria Matejka
c836bd388d Filter: functions can and should have typed return values 2023-06-15 14:00:11 +02:00
Maria Matejka
27ac8cb2ca GitLab: Disabling build for CentOS 7 and Ubuntu 14.04 as our build machines don't like C11 2023-06-15 14:00:11 +02:00
Maria Matejka
3272dceb38 Filter/Conf: Method names have their own keyword hash
To allow for future dynamic method definition, parsing method names is
done via a dedicated keyword hash/scope.
2023-06-13 12:26:50 +02:00
Maria Matejka
317c89cc8a Conf: Allowing conf scope to be explicitly read only 2023-06-13 11:09:41 +02:00
Maria Matejka
08d4205754 Conf: Symbol manipulation gets its context explicitly 2023-06-13 10:51:03 +02:00
Maria Matejka
3834ce040a Filter: any lvalue can get its methods called 2023-06-12 11:40:05 +02:00
Maria Matejka
3a221a74ef Filter: split out dot-notation methods to separate targets
This is just a preparationary refactoring to allow type-based method
tables.
2023-06-12 11:20:49 +02:00
Maria Matejka
72f3189ca5 Conf: Keywords have their default symbols
This avoids unnecessary collapsed soft scopes caused by keyword symbol multiallocation.
2023-06-09 23:22:21 +02:00
Maria Matejka
df338396cd Conf: Symbol hashes for all scopes
This is a backport cherry-pick of commits
  165156beeb
  cce974e8ea

from the v3.0 branch as we need symbol hashes directly inside their
scopes for more general usage than before.

The redefinable keywords must be specified in any .Y file as follows:

  toksym: THE_KEYWORD ;
2023-06-09 13:49:31 +02:00
Maria Matejka
a19a60bd6c Dropping empty-type const f_vals, they were copied anyway 2023-06-09 13:49:31 +02:00
Maria Matejka
bc19167135 Conf: Adding dummy thread-number setting for easier sharing of configuration between v2 and v3 2023-06-09 13:49:31 +02:00
Ondrej Zajicek
69372dc9aa Babel: Minor changes to RTT formatting
Use existing %t printf code and move 'ms' in CLI output to table header.
2023-06-02 02:34:05 +02:00
Toke Høiland-Jørgensen
f08abcb8dd Babel: Add support for the RTT extension
This adds support to the Babel protocol for the RTT extension specified
in draft-ietf-babel-rtt-extension. While this extension is not yet at the
RFC stage, it is one of the more useful extensions to Babel[0], so it
seems worth having in Bird as well.

The extension adds timestamps to Hello and IHU TLVs and uses these to
compute an RTT to each neighbour. An extra per-neighbour cost is then
computed from the RTT based on a minimum and maximum interval and cost
value specified in the configuration. The primary use case for this is
improving routing in a geographically distributed tunnel-based overlay
network.

The implementation follows the babeld implementation when picking
constants and default configuration values. It also uses the same RTT
smoothing algorithm as babeld, and follows it in adding a new 'tunnel'
interface type which enables RTT by default.

[0] https://alioth-lists.debian.net/pipermail/babel-users/2022-April/003932.html
2023-06-02 00:31:53 +02:00
Toke Høiland-Jørgensen
d8cf3cad51 IO: Add current_time_now() function for immediate timestamp
Add a current_time_now() function which gets an immediate monotonic
timestamp instead of using the cached value from the event loop. This is
useful for callers that need precise times, such as the Babel RTT
measurement code.

Minor changes by committer.
2023-06-02 00:26:41 +02:00
Ondrej Zajicek
f8ba82804f BGP: Fix role check when no capability option is present
When an OPEN message without capability options was parsed, the remote
role field was not initialized with the proper (non-zero) default value,
so it was interpreted as if 'provider' was announced.

Thanks to Mikhail Grishin for the bugreport.
2023-05-19 01:02:57 +02:00
Ondrej Zajicek
b0e97617d9 Lib: Improve IP/net hashing
Backport some changes from branch oz-parametric-hashes. Replace naive
hash function for IPv6 addresses, fix hashing of VPNx (where upper half
of RD was ignored), fix hashing of MPLS labels (where identity was used).
2023-05-18 16:02:02 +02:00
Ondrej Zajicek
3cf91fb9eb Nest: Add tests and benchmark for FIB
Basic fib_get() / fib_find() test for random prefixes, FIB_WALK() test,
and benchmark for fib_find(). Also generalize and reuse some code from
trie tests.
2023-05-16 13:25:48 +02:00
Ondrej Zajicek
a8a64ca0fe Conf: Improve handling of keywords
For whatever reason, parser allocated a symbol for every parsed keyword
in each scope. That wasted time and memory. The effect is worsened with
recent changes allowing local scopes, so keywords often promote soft
scopes (with no symbols) to real scopes.

Do not allocate a symbol for a keyword. Take care of keywords that could
be promoted to symbols (kw_sym) and do it explicitly.
2023-04-27 18:41:01 +02:00
Ondrej Zajicek
9b471e72d7 Conf: Fix symbol lookup
The symbol table used just symbol name as a key, and used a trick with
active flag to find symbols in active scopes with one hash table lookup.

The disadvantage is that it can degenerate to O(n) for negative queries
in situations where are many symbols with the same name in different
scopes.

Thanks to Yanko Kaneti for the bugreport.
2023-04-27 17:09:00 +02:00
Ondrej Zajicek
ca0f239c72 NEWS and version update 2023-04-21 20:26:47 +02:00