mirrors/bird
mirrors/bird
0
0
Fork 0
mirror of https://gitlab.nic.cz/labs/bird.git synced 2024-12-23 02:01:55 +00:00
Code Releases Activity

SNMP: Minor changes

Browse Source
This commit is contained in:
Vojtech Vilimek 2024-08-14 17:34:12 +02:00
parent 6cfa5416e1
commit 28c93bd8fa
2 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
proto/snmp/snmp_utils.c
View File

@ -1000,7 +1000,6 @@ snmp_walk_init(struct mib_tree *tree, struct mib_walk_state *walk, struct snmp_p
return (!node || !mib_node_is_leaf(node)) ? NULL : &node->leaf; return (!node || !mib_node_is_leaf(node)) ? NULL : &node->leaf;
} }
// TODO alter the varbind
struct mib_leaf * struct mib_leaf *
snmp_walk_next(struct mib_tree *tree, struct mib_walk_state *walk, struct snmp_pdu *c) snmp_walk_next(struct mib_tree *tree, struct mib_walk_state *walk, struct snmp_pdu *c)
{ {

3
proto/snmp/subagent.c
View File

@ -77,7 +77,6 @@ snmp_blank_header(struct agentx_header *h, enum agentx_pdu_types type)
* snmp_register_ack - handle registration response * snmp_register_ack - handle registration response
* @p: SNMP protocol instance * @p: SNMP protocol instance
* @res: header of agentx-Response-PDU * @res: header of agentx-Response-PDU
* @oid: MIB subtree Object Identifier in cpu native byte order
*/ */
void void
snmp_register_ack(struct snmp_proto *p, struct agentx_response *res) snmp_register_ack(struct snmp_proto *p, struct agentx_response *res)
@ -781,7 +780,6 @@ parse_response(struct snmp_proto *p, byte *res)
case AGENTX_RES_DUPLICATE_REGISTER: case AGENTX_RES_DUPLICATE_REGISTER:
case AGENTX_RES_REQUEST_DENIED: case AGENTX_RES_REQUEST_DENIED:
case AGENTX_RES_UNKNOWN_REGISTER: case AGENTX_RES_UNKNOWN_REGISTER:
// TODO more direct path to mib-specific code
TRACE(D_PACKETS, "SNMP received agentx-Response-PDU with error %u", r->error); TRACE(D_PACKETS, "SNMP received agentx-Response-PDU with error %u", r->error);
snmp_register_ack(p, r); snmp_register_ack(p, r);
break; break;
@ -974,7 +972,6 @@ static inline void
response_err_ind(struct agentx_response *res, enum agentx_response_errs err, u16 ind) response_err_ind(struct agentx_response *res, enum agentx_response_errs err, u16 ind)
{ {
STORE_U16(res->error, (u16) err); STORE_U16(res->error, (u16) err);
// TODO deal with auto-incrementing of snmp_pdu context c.ind
if (err != AGENTX_RES_NO_ERROR && err != AGENTX_RES_GEN_ERROR) if (err != AGENTX_RES_NO_ERROR && err != AGENTX_RES_GEN_ERROR)
{ {
//TRACE(D_PACKETS, "Last PDU resulted in error %u", err); //TRACE(D_PACKETS, "Last PDU resulted in error %u", err);