From 28c93bd8fad49d8219d197417998e64503eb9e0e Mon Sep 17 00:00:00 2001 From: Vojtech Vilimek Date: Wed, 14 Aug 2024 17:34:12 +0200 Subject: [PATCH] SNMP: Minor changes --- proto/snmp/snmp_utils.c | 1 - proto/snmp/subagent.c | 3 --- 2 files changed, 4 deletions(-) diff --git a/proto/snmp/snmp_utils.c b/proto/snmp/snmp_utils.c index 9540517e..10febdd6 100644 --- a/proto/snmp/snmp_utils.c +++ b/proto/snmp/snmp_utils.c @@ -1000,7 +1000,6 @@ snmp_walk_init(struct mib_tree *tree, struct mib_walk_state *walk, struct snmp_p return (!node || !mib_node_is_leaf(node)) ? NULL : &node->leaf; } -// TODO alter the varbind struct mib_leaf * snmp_walk_next(struct mib_tree *tree, struct mib_walk_state *walk, struct snmp_pdu *c) { diff --git a/proto/snmp/subagent.c b/proto/snmp/subagent.c index d86917c8..414e04ff 100644 --- a/proto/snmp/subagent.c +++ b/proto/snmp/subagent.c @@ -77,7 +77,6 @@ snmp_blank_header(struct agentx_header *h, enum agentx_pdu_types type) * snmp_register_ack - handle registration response * @p: SNMP protocol instance * @res: header of agentx-Response-PDU - * @oid: MIB subtree Object Identifier in cpu native byte order */ void snmp_register_ack(struct snmp_proto *p, struct agentx_response *res) @@ -781,7 +780,6 @@ parse_response(struct snmp_proto *p, byte *res) case AGENTX_RES_DUPLICATE_REGISTER: case AGENTX_RES_REQUEST_DENIED: case AGENTX_RES_UNKNOWN_REGISTER: - // TODO more direct path to mib-specific code TRACE(D_PACKETS, "SNMP received agentx-Response-PDU with error %u", r->error); snmp_register_ack(p, r); break; @@ -974,7 +972,6 @@ static inline void response_err_ind(struct agentx_response *res, enum agentx_response_errs err, u16 ind) { STORE_U16(res->error, (u16) err); - // TODO deal with auto-incrementing of snmp_pdu context c.ind if (err != AGENTX_RES_NO_ERROR && err != AGENTX_RES_GEN_ERROR) { //TRACE(D_PACKETS, "Last PDU resulted in error %u", err);