mirrors/phpv8
mirrors/phpv8
0
0
Fork 0
mirror of https://github.com/phpv8/v8js.git synced 2024-12-22 22:51:51 +00:00
Code Releases Activity

delete v8::Extension instance on shutdown

Browse Source
This commit is contained in:
Stefan Siegl 2015-08-02 19:42:42 +02:00
parent 4650273c90
commit dd4996cd56
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
v8js_class.cc
View File

@ -62,6 +62,7 @@ struct v8js_jsext {
int deps_count; int deps_count;
char *name; char *name;
char *source; char *source;
v8::Extension *extension;
}; };
/* }}} */ /* }}} */
@ -241,6 +242,7 @@ static void v8js_jsext_dtor(v8js_jsext *jsext) /* {{{ */
if (jsext->deps) { if (jsext->deps) {
v8js_free_ext_strarr(jsext->deps, jsext->deps_count); v8js_free_ext_strarr(jsext->deps, jsext->deps_count);
} }
delete jsext->extension;
free(jsext->name); free(jsext->name);
free(jsext->source); free(jsext->source);
} }
@ -822,15 +824,16 @@ static int v8js_register_extension(char *name, uint name_len, char *source, uint
zend_hash_copy(jsext->deps_ht, Z_ARRVAL_P(deps_arr), (copy_ctor_func_t) v8js_persistent_zval_ctor, NULL, sizeof(zval *)); zend_hash_copy(jsext->deps_ht, Z_ARRVAL_P(deps_arr), (copy_ctor_func_t) v8js_persistent_zval_ctor, NULL, sizeof(zval *));
} }
jsext->extension = new v8::Extension(jsext->name, jsext->source, jsext->deps_count, jsext->deps);
if (zend_hash_add(V8JSG(extensions), name, name_len + 1, jsext, sizeof(v8js_jsext), NULL) == FAILURE) { if (zend_hash_add(V8JSG(extensions), name, name_len + 1, jsext, sizeof(v8js_jsext), NULL) == FAILURE) {
v8js_jsext_dtor(jsext); v8js_jsext_dtor(jsext);
free(jsext); free(jsext);
return FAILURE; return FAILURE;
} }
v8::Extension *extension = new v8::Extension(jsext->name, jsext->source, jsext->deps_count, jsext->deps); jsext->extension->set_auto_enable(auto_enable ? true : false);
extension->set_auto_enable(auto_enable ? true : false); v8::RegisterExtension(jsext->extension);
v8::RegisterExtension(extension);
free(jsext); free(jsext);