mirrors/phpv8
mirrors/phpv8
0
0
Fork 0
mirror of https://github.com/phpv8/v8js.git synced 2025-01-03 09:21:51 +00:00
Code Releases Activity

Merge pull request #14 from stesie/fix-temp-context-leak

Browse Source 
Memory leak in php_v8js_v8_get_properties
This commit is contained in:
Patrick Reilly 2013-06-10 09:50:25 -07:00
commit d7bded2a31
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
v8js.cc
View File

@ -231,12 +231,15 @@ static HashTable *php_v8js_v8_get_properties(zval *object TSRMLS_DC) /* {{{ */
v8::Locker locker(obj->isolate); v8::Locker locker(obj->isolate);
v8::Isolate::Scope isolate_scope(obj->isolate); v8::Isolate::Scope isolate_scope(obj->isolate);
v8::HandleScope local_scope(obj->isolate); v8::HandleScope local_scope(obj->isolate);
v8::Handle<v8::Context> temp_context = v8::Context::New(); v8::Persistent<v8::Context> temp_context = v8::Context::New();
v8::Context::Scope temp_scope(temp_context); v8::Context::Scope temp_scope(temp_context);
if (php_v8js_v8_get_properties_hash(obj->v8obj, retval, obj->flags, obj->isolate TSRMLS_CC) == SUCCESS) { if (php_v8js_v8_get_properties_hash(obj->v8obj, retval, obj->flags, obj->isolate TSRMLS_CC) == SUCCESS) {
temp_context.Dispose();
return retval; return retval;
} }
temp_context.Dispose();
return NULL; return NULL;
} }
/* }}} */ /* }}} */