From 8e8306ae3e3c3619b639ef390f3d257091d18a76 Mon Sep 17 00:00:00 2001 From: Stefan Siegl Date: Sun, 24 Sep 2017 13:59:34 +0200 Subject: [PATCH 1/2] allow enumeration of methods -> actually our properties said this shouldn't be possible -> however v8js_named_property_enumerator enumerated the methods -> older V8 versions listed the methods anyways -> V8 6.3 started to not list the method now refs #326 --- v8js_object_export.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/v8js_object_export.cc b/v8js_object_export.cc index d733ae2..ece7b5d 100644 --- a/v8js_object_export.cc +++ b/v8js_object_export.cc @@ -664,8 +664,7 @@ v8::Local v8js_named_property_callback(v8::Local property } } } else if (callback_type == V8JS_PROP_QUERY) { - // methods are not enumerable - ret_value = V8JS_UINT(v8::ReadOnly|v8::DontEnum|v8::DontDelete); + ret_value = V8JS_UINT(v8::ReadOnly|v8::DontDelete); } else if (callback_type == V8JS_PROP_SETTER) { ret_value = set_value; // lie. this field is read-only. } else if (callback_type == V8JS_PROP_DELETER) { From 6b275c5b6eafc2b304abdb9e3fe49312ebaf9471 Mon Sep 17 00:00:00 2001 From: Stefan Siegl Date: Sun, 24 Sep 2017 13:59:56 +0200 Subject: [PATCH 2/2] (Vagrantfile) add V8 6.3 --- Vagrantfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Vagrantfile b/Vagrantfile index 72c19a3..1da40b0 100644 --- a/Vagrantfile +++ b/Vagrantfile @@ -18,7 +18,7 @@ Vagrant.configure("2") do |config| # # mass-define "generic" Ubuntu boxes # - %w{5.7 5.8 5.9 6.0}.each { |version| + %w{5.7 5.8 5.9 6.0 6.3}.each { |version| config.vm.define "v8-#{version}" do |i| i.vm.synced_folder ".", "/data/v8js"