mirrors/phpv8
mirrors/phpv8
0
0
Fork 0
mirror of https://github.com/phpv8/v8js.git synced 2024-12-22 12:51:52 +00:00
Code Releases Activity

don't free interned strings on PHP >= 7.3

Browse Source
This commit is contained in:
Stefan Siegl 2018-07-13 14:19:02 +02:00
parent 2c9d683e86
commit aa041b4597
No known key found for this signature in database
GPG Key ID: 73942AF5642F3DDA
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
v8js_class.cc
View File

@ -983,12 +983,14 @@ static void v8js_persistent_zval_ctor(zval *p) /* {{{ */
} }
/* }}} */ /* }}} */
#if PHP_VERSION_ID < 70300
static void v8js_persistent_zval_dtor(zval *p) /* {{{ */ static void v8js_persistent_zval_dtor(zval *p) /* {{{ */
{ {
assert(Z_TYPE_P(p) == IS_STRING); assert(Z_TYPE_P(p) == IS_STRING);
free(Z_STR_P(p)); free(Z_STR_P(p));
} }
/* }}} */ /* }}} */
#endif
static void v8js_script_free(v8js_script *res) static void v8js_script_free(v8js_script *res)
{ {
@ -1052,7 +1054,11 @@ static int v8js_register_extension(zend_string *name, zend_string *source, zval
if (jsext->deps) { if (jsext->deps) {
jsext->deps_ht = (HashTable *) malloc(sizeof(HashTable)); jsext->deps_ht = (HashTable *) malloc(sizeof(HashTable));
#if PHP_VERSION_ID < 70300
zend_hash_init(jsext->deps_ht, jsext->deps_count, NULL, v8js_persistent_zval_dtor, 1); zend_hash_init(jsext->deps_ht, jsext->deps_count, NULL, v8js_persistent_zval_dtor, 1);
#else
zend_hash_init(jsext->deps_ht, jsext->deps_count, NULL, NULL, 1);
#endif
zend_hash_copy(jsext->deps_ht, Z_ARRVAL_P(deps_arr), v8js_persistent_zval_ctor); zend_hash_copy(jsext->deps_ht, Z_ARRVAL_P(deps_arr), v8js_persistent_zval_ctor);
} }