mirrors/phpv8
mirrors/phpv8
0
0
Fork 0
mirror of https://github.com/phpv8/v8js.git synced 2024-12-22 19:51:51 +00:00
Code Releases Activity

allow enumeration of methods

Browse Source 
-> actually our properties said this shouldn't be possible
-> however v8js_named_property_enumerator enumerated the methods
-> older V8 versions listed the methods anyways
-> V8 6.3 started to not list the method now

refs #326
This commit is contained in:
Stefan Siegl 2017-09-24 13:59:34 +02:00
parent fb0b0c1f07
commit 8e8306ae3e
No known key found for this signature in database
GPG Key ID: B224EC6857AD7F9B
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
v8js_object_export.cc
View File

@ -664,8 +664,7 @@ v8::Local<v8::Value> v8js_named_property_callback(v8::Local<v8::String> property
} }
} }
} else if (callback_type == V8JS_PROP_QUERY) { } else if (callback_type == V8JS_PROP_QUERY) {
// methods are not enumerable ret_value = V8JS_UINT(v8::ReadOnly|v8::DontDelete);
ret_value = V8JS_UINT(v8::ReadOnly|v8::DontEnum|v8::DontDelete);
} else if (callback_type == V8JS_PROP_SETTER) { } else if (callback_type == V8JS_PROP_SETTER) {
ret_value = set_value; // lie. this field is read-only. ret_value = set_value; // lie. this field is read-only.
} else if (callback_type == V8JS_PROP_DELETER) { } else if (callback_type == V8JS_PROP_DELETER) {