mirrors/phpv8
mirrors/phpv8
0
0
Fork 0
mirror of https://github.com/phpv8/v8js.git synced 2025-01-03 10:21:51 +00:00
Code Releases Activity

Simplify php_v8js_weak_object_callback.

Browse Source 
This also fixes a leak in the `object_dom` testcase, where the DOM extension
returns an object with refcnt 1 but object_store refcnt 2, causing
READY_TO_DESTROY to return false.  Don't try to be fancy, just use the
standard PHP destructor.
This commit is contained in:
C. Scott Ananian 2013-10-27 12:33:19 -04:00
parent a730ddeb67
commit 892c654c8c
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
v8js_convert.cc
View File

@ -260,12 +260,7 @@ static void php_v8js_weak_object_callback(const v8::WeakCallbackData<v8::Object,
v8::Isolate *isolate = data.GetIsolate(); v8::Isolate *isolate = data.GetIsolate();
zval *value = data.GetParameter(); zval *value = data.GetParameter();
V8JS_TSRMLS_FETCH(); V8JS_TSRMLS_FETCH();
if (READY_TO_DESTROY(value)) { zval_ptr_dtor(&value);
zval_dtor(value);
FREE_ZVAL(value);
} else {
Z_DELREF_P(value);
}
v8::V8::AdjustAmountOfExternalAllocatedMemory(-1024); v8::V8::AdjustAmountOfExternalAllocatedMemory(-1024);
} }