mirrors/phpv8
mirrors/phpv8
0
0
Fork 0
mirror of https://github.com/phpv8/v8js.git synced 2024-12-22 09:21:52 +00:00
Code Releases Activity

forward exceptions thrown in module loader

Browse Source
This commit is contained in:
Stefan Siegl 2016-07-03 22:52:50 +02:00
parent 4161008417
commit 7dcebdd927
2 changed files with 44 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
tests/commonjs_exception_001.phpt Normal file
View File

@ -0,0 +1,35 @@
--TEST--
Test V8Js::setModuleLoader : Forward exceptions
--SKIPIF--
<?php require_once(dirname(__FILE__) . '/skipif.inc'); ?>
--FILE--
<?php
$JS = <<< EOT
var foo = require("./test");
EOT;
$v8 = new V8Js();
$v8->setModuleLoader(function($module) {
throw new Exception('some exception');
});
$v8->executeString($JS, 'module.js', V8Js::FLAG_PROPAGATE_PHP_EXCEPTIONS);
?>
===EOF===
--EXPECTF--
Fatal error: Uncaught Exception: some exception in %s%ecommonjs_exception_001.php:9
Stack trace:
#0 [internal function]: {closure}('test')
#1 %s%ecommonjs_exception_001.php(12): V8Js->executeString('var foo = requi...', 'module.js', 4)
#2 {main}
Next V8JsScriptException: module.js:1: Exception: some exception in %s%ecommonjs_exception_001.php:9
Stack trace:
#0 [internal function]: {closure}('test')
#1 %s%ecommonjs_exception_001.php(12): V8Js->executeString('var foo = requi...', 'module.js', 4)
#2 {main} in %s%ecommonjs_exception_001.php:12
Stack trace:
#0 %s%ecommonjs_exception_001.php(12): V8Js->executeString('var foo = requi...', 'module.js', 4)
#1 {main}
thrown in %s%ecommonjs_exception_001.php on line 12

12
v8js_methods.cc
View File

@ -390,9 +390,15 @@ V8JS_METHOD(require)
efree(normalised_module_id); efree(normalised_module_id);
efree(normalised_path); efree(normalised_path);
// Clear the PHP exception and throw it in V8 instead if (c->flags & V8JS_FLAG_PROPAGATE_PHP_EXCEPTIONS) {
zend_clear_exception(TSRMLS_C); zval tmp_zv;
info.GetReturnValue().Set(isolate->ThrowException(V8JS_SYM("Module loader callback exception"))); ZVAL_OBJ(&tmp_zv, EG(exception));
info.GetReturnValue().Set(isolate->ThrowException(zval_to_v8js(&tmp_zv, isolate)));
zend_clear_exception();
} else {
v8js_terminate_execution(isolate);
}
return; return;
} }