mirrors/phpv8
mirrors/phpv8
0
0
Fork 0
mirror of https://github.com/phpv8/v8js.git synced 2024-12-22 20:51:51 +00:00
Code Releases Activity

Document rules for initialization/cleanup of ZTS globals.

Browse Source 
Transfer stesie's comment from the c3512587ac
commit message so that future additions to v8js_globals maintain the
proper ZTS behavior.
This commit is contained in:
C. Scott Ananian 2013-10-26 22:38:44 -04:00
parent ae2ad9967d
commit 7cdcb5f45e
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
v8js.cc
View File

@ -1670,6 +1670,16 @@ static PHP_MINFO_FUNCTION(v8js)
*/ */
static PHP_GINIT_FUNCTION(v8js) static PHP_GINIT_FUNCTION(v8js)
{ {
/*
If ZTS is disabled, the v8js_globals instance is declared right
in the BSS and hence automatically initialized by C++ compiler.
Most of the variables are just zeroed.
If ZTS is enabled however, v8js_globals just points to a freshly
allocated, uninitialized piece of memory, hence we need to
initialize all fields on our own. Likewise on shutdown we have to
run the destructors manually.
*/
#ifdef ZTS #ifdef ZTS
v8js_globals->extensions = NULL; v8js_globals->extensions = NULL;
v8js_globals->v8_initialized = 0; v8js_globals->v8_initialized = 0;