From 2ab2549d0234cfae4e666a4d67e1554f60efb8bb Mon Sep 17 00:00:00 2001 From: Bernie Reiter Date: Fri, 30 Dec 2016 23:10:10 +0100 Subject: [PATCH] README.Linux.md: Add is_component_build flag to v8gen.py command Previously, it was appended using `echo >>`. However, that wasn't picked up by `ninja` since it would've required an intermediary `gn gen out.gn/x64.release` step. By passing the additional build flag directly to `v8gen.py`, we ensure that `ninja` picks it up. --- README.Linux.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/README.Linux.md b/README.Linux.md index 7a9d6b9..358063f 100644 --- a/README.Linux.md +++ b/README.Linux.md @@ -55,8 +55,7 @@ git checkout 5.6.326.12 gclient sync # Setup GN -tools/dev/v8gen.py -vv x64.release -echo is_component_build = true >> out.gn/x64.release/args.gn +tools/dev/v8gen.py -vv x64.release -- is_component_build=true # Build ninja -C out.gn/x64.release/