mirrors/phpv8
mirrors/phpv8
0
0
Fork 0
mirror of https://github.com/phpv8/v8js.git synced 2025-01-03 14:31:53 +00:00
Code Releases Activity

Fix tests/var_dump.phpt

Browse Source 
Recent V8 versions (e.g. 4.8.253 or 4.9.19) consider
`IsFunction() = true` for Closure objects from PHP; but earlier
versions didn't.

This ensures consistent var_dump behaviour (sticking to the
behaviour with older V8 versions).
This commit is contained in:
Stefan Siegl 2015-11-28 15:18:38 +01:00
parent 4376d59942
commit 670554306a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
v8js_methods.cc
View File

@ -138,7 +138,7 @@ static void v8js_dumper(v8::Isolate *isolate, v8::Local<v8::Value> var, int leve
V8JS_GET_CLASS_NAME(cname, object); V8JS_GET_CLASS_NAME(cname, object);
int hash = object->GetIdentityHash(); int hash = object->GetIdentityHash();
if (var->IsFunction()) if (var->IsFunction() && strcmp(ToCString(cname), "Closure") != 0)
{ {
v8::String::Utf8Value csource(object->ToString()); v8::String::Utf8Value csource(object->ToString());
php_printf("object(Closure)#%d {\n%*c%s\n", hash, level * 2 + 2, ' ', ToCString(csource)); php_printf("object(Closure)#%d {\n%*c%s\n", hash, level * 2 + 2, ' ', ToCString(csource));