From 54e3a07bc8f6b4d5a2a44be8c6091f7b83a333b4 Mon Sep 17 00:00:00 2001 From: Stefan Siegl Date: Tue, 14 Mar 2017 07:26:54 +0100 Subject: [PATCH] make exception_start_column.phpt green again, closes #302 Test began to fail with V8 ~5.9.35 which started to report different column numbers of errors. Adapt test so it works well with older and newer versions of V8. --- tests/exception_start_column.phpt | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/tests/exception_start_column.phpt b/tests/exception_start_column.phpt index 682e290..9598bc1 100644 --- a/tests/exception_start_column.phpt +++ b/tests/exception_start_column.phpt @@ -6,15 +6,23 @@ Test V8::executeString() : Test getJsStartColumn on script exception executeString("print(blar());"); } -catch(V8JsScriptException $e) { - var_dump($e->getJsStartColumn()); +catch(V8JsScriptException $a) { } + +try { + $v8->executeString("(null); print(blar());"); } +catch(V8JsScriptException $b) { } + +var_dump($b->getJsStartColumn() - $a->getJsStartColumn()); ?> ===EOF=== --EXPECT-- -int(6) +int(8) ===EOF===