mirrors/phpv8
mirrors/phpv8
0
0
Fork 0
mirror of https://github.com/phpv8/v8js.git synced 2025-01-03 10:21:51 +00:00
Code Releases Activity

Fix for V8 timezone notification

Browse Source
This commit is contained in:
Mark Grainger 2022-05-30 20:24:55 +00:00
parent 362868888f
commit 51d34e0acd
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tests/timezones.phpt
View File

@ -1,8 +1,6 @@
--TEST-- --TEST--
Test V8::executeString() : Check timezone handling Test V8::executeString() : Check timezone handling
--SKIPIF-- --SKIPIF--
SKIP test currently broken, see #378
<?php <?php
if(strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') { if(strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {
die('SKIP TZ not handled by v8 on Windows'); die('SKIP TZ not handled by v8 on Windows');
@ -39,7 +37,7 @@ try {
?> ?>
===EOF=== ===EOF===
--EXPECT-- --EXPECT--
Thu Mar 20 2014 11:03:24 GMT+0200 (EET) Thu Mar 20 2014 11:03:24 GMT+0200 (Eastern European Standard Time)
Thu Mar 20 2014 05:03:24 GMT-0400 (EDT) Thu Mar 20 2014 05:03:24 GMT-0400 (Eastern Daylight Time)
Thu Mar 20 2014 11:03:24 GMT+0200 (EET) Thu Mar 20 2014 11:03:24 GMT+0200 (Eastern European Standard Time)
===EOF=== ===EOF===

2
v8js_v8.cc
View File

@ -148,7 +148,7 @@ void v8js_v8_call(v8js_ctx *c, zval **return_value,
c->tz = strdup(tz); c->tz = strdup(tz);
} }
else if (strcmp(c->tz, tz) != 0) { else if (strcmp(c->tz, tz) != 0) {
c->isolate->DateTimeConfigurationChangeNotification(); c->isolate->DateTimeConfigurationChangeNotification(v8::Isolate::TimeZoneDetection::kRedetect);
free(c->tz); free(c->tz);
c->tz = strdup(tz); c->tz = strdup(tz);