From 22a6d354596a5db248f6d19f6daa121175c91fdd Mon Sep 17 00:00:00 2001 From: Stefan Siegl Date: Sat, 22 Jun 2019 19:34:55 +0200 Subject: [PATCH] declare windows as officially unsupported (since currently broken anyways) --- README.Win32.md | 5 +++ README.md | 9 ++-- appveyor.yml | 108 ------------------------------------------------ 3 files changed, 11 insertions(+), 111 deletions(-) delete mode 100644 appveyor.yml diff --git a/README.Win32.md b/README.Win32.md index 7db9dcf..62c3159 100644 --- a/README.Win32.md +++ b/README.Win32.md @@ -5,6 +5,11 @@ The V8Js PHP extension is primarily targeted at Unix platforms, especially GNU/Linux. However it is possible (and supported) to build on Windows, using Microsoft Visual Studio. + +**These instructions are pretty dated, and Windows is not currently a officially supported target of php-v8js.** +If you would like to make it work again, feel free to do so and provide Pull Requests as you see fit. + + Building with MinGW or Cygwin is not officially supported; mainly since Google v8 does not support builds on Cygwin (and building it on Cygwin is currently broken). diff --git a/README.md b/README.md index 57ddeb6..55ed233 100644 --- a/README.md +++ b/README.md @@ -2,7 +2,6 @@ V8Js ==== [![Build Status](https://travis-ci.org/phpv8/v8js.svg?branch=php7)](https://travis-ci.org/phpv8/v8js) -[![Windows Build Status](https://ci.appveyor.com/api/projects/status/gr8fkq8c08s06h31/branch/php7?svg=true)](https://ci.appveyor.com/project/stesie/v8js) [![GitHub license](https://img.shields.io/badge/license-MIT-blue.svg)](https://raw.githubusercontent.com/phpv8/v8js/master/LICENSE) [![Join the chat at https://gitter.im/phpv8/v8js](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/phpv8/v8js?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge) @@ -37,6 +36,12 @@ Minimum requirements This embedded implementation of the V8 engine uses thread locking so it works with ZTS enabled. +Windows is currently *not* officially supported. Mostly since I don't have the time to +maintain support for it myself, and don't really have Windows boxes to try things with. +It would be great if someone could step up and fix things on Windows, provide pre-build V8 +binaries, etc. + + Pre-built binaries ------------------ @@ -52,8 +57,6 @@ You might want to install these and compile V8Js based on them. There also is a Heroku extension pack that has recent V8Js versions for PHP 7.x, see [@stesie's blog post](https://stesie.github.io/2016/03/heroku-custom-platform-repo) for details. -64-bit binaries for Windows [are made available by Jan-E here](https://www.apachelounge.com/viewtopic.php?t=6359). - Compiling latest version ------------------------ diff --git a/appveyor.yml b/appveyor.yml deleted file mode 100644 index 920792d..0000000 --- a/appveyor.yml +++ /dev/null @@ -1,108 +0,0 @@ -environment: - matrix: - - ARTIFACT_NAME: v8js_vc15_php-7.3_%Platform%_ts.zip - OUTDIR: Release_TS - V8_ASSETS: V8-7.0.276.11-vc15-%Platform%.zip - PHP_VERSION: 7.3.0RC1 - - ARTIFACT_NAME: v8js_vc15_php-7.3_%Platform%_nts.zip - OUTDIR: Release - CONFIGURE_EXTRA: --disable-zts - V8_ASSETS: V8-7.0.276.11-vc15-%Platform%.zip - PHP_VERSION: 7.3.0RC1 - - ARTIFACT_NAME: v8js_vc15_php-7.2_%Platform%_ts.zip - OUTDIR: Release_TS - V8_ASSETS: V8-7.0.276.11-vc15-%Platform%.zip - PHP_VERSION: 7.2.10 - - ARTIFACT_NAME: v8js_vc15_php-7.2_%Platform%_nts.zip - OUTDIR: Release - CONFIGURE_EXTRA: --disable-zts - V8_ASSETS: V8-7.0.276.11-vc15-%Platform%.zip - PHP_VERSION: 7.2.10 - - PHP_SDK: c:\projects\php-sdk - -os: Visual Studio 2017 -clone_folder: c:\projects\php-sdk\v8js-ci\vc15\%Platform%\php\ext\v8js - -platform: - - x64 - - x86 - -install: - - cd %PHP_SDK% - - curl -fSL -o php-sdk-2.1.9beta1.zip "https://github.com/Microsoft/php-sdk-binary-tools/archive/php-sdk-2.1.9beta1.zip" - - 7z.exe x php-sdk-2.1.9beta1.zip - - move /y php-sdk-binary-tools-php-sdk-2.1.9beta1\* . - - for /R /D %%f in (php-sdk-binary-tools-php-sdk-2.1.9beta1\*) do move /y %%f . - - call bin\phpsdk_setvars.bat - - call bin\phpsdk_buildtree.bat v8js-ci - - cd v8js-ci\vc15\%Platform% - - md deps - - cd deps - - curl -fSL -o %V8_ASSETS% "https://phpdev.toolsforresearch.com/%V8_ASSETS%" - - 7z.exe x %V8_ASSETS% - - dir - - curl -fSL -o libiconv.zip "https://windows.php.net/downloads/php-sdk/deps/vc15/%Platform%/libiconv-1.15-3-vc15-%Platform%.zip" - - 7z.exe x libiconv.zip -y - - curl -fSL -o libxml2.zip "https://windows.php.net/downloads/php-sdk/deps/vc15/%Platform%/libxml2-2.9.8-vc15-%Platform%.zip" - - 7z.exe x libxml2.zip -y - - cd .. - - curl -fSL -o "php-%PHP_VERSION%.tar.gz" "https://github.com/php/php-src/archive/php-%PHP_VERSION%.tar.gz" - - ren php php-src-php-%PHP_VERSION% - - 7z.exe x php-%PHP_VERSION%.tar.gz -y - - 7z.exe x php-%PHP_VERSION%.tar -y | find /v "Extracting" - - dir - - ren php-src-php-%PHP_VERSION% php-%PHP_VERSION% - - cd php-%PHP_VERSION% - - IF "%Platform%" == "x64" SET OUTDIR=x64\%OUTDIR% - - mkdir %OUTDIR% - - move ..\deps\bin\*.dll %OUTDIR%\ - - move ..\deps\bin\icudtl.dat %OUTDIR%\ - -build_script: - - ps: >- - If ($env:Platform -Match "x86") { - $env:VCVARS_PLATFORM="x86" - $env:ENV_PLATFORM="x86" - } Else { - $env:VCVARS_PLATFORM="amd64" - $env:ENV_PLATFORM="x64" - } - - call "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\vcvarsall.bat" %VCVARS_PLATFORM% - - cd - - echo Building PHP [%PHP_VERSION%] - - '%PHP_SDK%\bin\phpsdk_setvars' - - buildconf - - configure --disable-all --enable-cli --with-iconv=yes --with-libxml=yes --with-dom=yes --enable-json=static --with-v8js %CONFIGURE_EXTRA% - - nmake - -after_build: - - cd %OUTDIR% - - 7z a %ARTIFACT_NAME% icudtl.dat icu*.dll v8.dll php_v8js.dll - - ps: Push-AppveyorArtifact $env:ARTIFACT_NAME - -test_script: - - cd c:\projects\php-sdk\v8js-ci\vc15\%Platform%\php-%PHP_VERSION% - - set NO_INTERACTION=1 - - set TEST_PHP_JUNIT=junit.xml - - set REPORT_EXIT_STATUS=1 - - "%OUTDIR%\\php.exe run-tests.php -p %OUTDIR%\\php.exe ext/v8js/tests/ -d v8js.icudtl_dat_path=%OUTDIR%/icudtl.dat -d extension=php_v8js.dll -d extension_dir=%OUTDIR%\\ --show-diff" - -on_finish: - - cd c:\projects\php-sdk\v8js-ci\vc15\%Platform%\php-%PHP_VERSION% - - ps: | - # upload results to AppVeyor - $wc = New-Object 'System.Net.WebClient' - $wc.UploadFile("https://ci.appveyor.com/api/testresults/junit/$($env:APPVEYOR_JOB_ID)", (Resolve-Path .\junit.xml)) - -deploy: - provider: S3 - access_key_id: AKIAJBJLBBZPMYOGVKEA - secret_access_key: - secure: N+jqdcvCOzqfrwL7ClIvcd9TkmQe9dghJwZMjLYtv7syVW5c4EU9YrqUbUUGmZ04 - bucket: win-phpv8 - set_public: true - artifact: "*.zip" - on: - branch: php7 -