From 0e76b675d22f487a2d0026f9bae97b7d078a918a Mon Sep 17 00:00:00 2001 From: Stefan Siegl Date: Wed, 11 Mar 2015 15:00:01 +0100 Subject: [PATCH] Require v8 3.24.6 or higher Just tested it, v8js builds correctly with 3.24.6 and fails to build against 3.24.5 due to `RequestInterrupt' being undefined. Syncing the check in config.m4 (used to test 3.21.12 or newer) against README.md file (which stated 3.24.10 or newer). --- README.md | 2 +- config.m4 | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index c0f0147..04c8c89 100644 --- a/README.md +++ b/README.md @@ -14,7 +14,7 @@ Minimum requirements V8 is Google's open source Javascript engine. V8 is written in C++ and is used in Google Chrome, the open source browser from Google. V8 implements ECMAScript as specified in ECMA-262, 5th edition. - This extension makes use of V8 isolates to ensure separation between multiple V8Js instances and uses the new isolate-based mechanism to throw exceptions, hence the need for 3.24.10 or above. + This extension makes use of V8 isolates to ensure separation between multiple V8Js instances and uses the new isolate-based mechanism to throw exceptions, hence the need for 3.24.6 or above. For a detailed overview of which V8 version V8Js can be successfully built against, see the [Jenkins V8Js build matrix](https://jenkins.brokenpipe.de/job/docker-v8js-matrix/). diff --git a/config.m4 b/config.m4 index 799068c..ffa6c8d 100644 --- a/config.m4 +++ b/config.m4 @@ -91,8 +91,8 @@ int main () set $ac_cv_v8_version IFS=$ac_IFS V8_API_VERSION=`expr [$]1 \* 1000000 + [$]2 \* 1000 + [$]3` - if test "$V8_API_VERSION" -lt 3021012 ; then - AC_MSG_ERROR([libv8 must be version 3.21.12 or greater]) + if test "$V8_API_VERSION" -lt 3024006 ; then + AC_MSG_ERROR([libv8 must be version 3.24.6 or greater]) fi AC_DEFINE_UNQUOTED([PHP_V8_API_VERSION], $V8_API_VERSION, [ ]) AC_DEFINE_UNQUOTED([PHP_V8_VERSION], "$ac_cv_v8_version", [ ])