From a3ed9196b9c08232ab426d9b8316cf1e1ffdbc2a Mon Sep 17 00:00:00 2001 From: "Edward Z. Yang" Date: Thu, 3 May 2007 03:15:29 +0000 Subject: [PATCH] Downgrade code-quality back to a txt scratchpad, add more items for AttrDef git-svn-id: http://htmlpurifier.org/svnroot/htmlpurifier/trunk@1010 48356398-32a2-884e-a903-53898d9a118a --- ...code-quality.html => dev-code-quality.txt} | 30 ++++--------------- docs/index.html | 9 ++++-- 2 files changed, 11 insertions(+), 28 deletions(-) rename docs/{dev-code-quality.html => dev-code-quality.txt} (58%) diff --git a/docs/dev-code-quality.html b/docs/dev-code-quality.txt similarity index 58% rename from docs/dev-code-quality.html rename to docs/dev-code-quality.txt index e815329a..7c09a22c 100644 --- a/docs/dev-code-quality.html +++ b/docs/dev-code-quality.txt @@ -1,31 +1,16 @@ - - - - - - -Code Quality Issues - HTML Purifier +Code Quality Issues - - -

Code Quality Issues

- -
Filed under Development
-
Return to the index.
-
HTML Purifier End-User Documentation
- -

Okay, face it. Programmers can get lazy, cut corners, or make mistakes. They +Okay, face it. Programmers can get lazy, cut corners, or make mistakes. They also can do quick prototypes, and then forget to rewrite them later. Well, while I can't list mistakes in here, I can list prototype-like segments of code that should be aggressively refactored. This does not list -optimization issues, that needs to be done after intense profiling.

+optimization issues, that needs to be done after intense profiling. -
 docs/examples/demo.php - ad hoc HTML/PHP soup to the extreme
 
-AttrDef
+AttrDef - a lot of duplication, more generic classes need to be created;
+a lot of strtolower() calls, no legit casing
     Class - doesn't support Unicode characters (fringe); uses regular
         expressions
     Lang - code duplication; premature optimization
@@ -45,8 +30,3 @@ URIScheme - needs to have callable generic checks
     mailto - doesn't validate emails, doesn't validate querystring
     news - doesn't validate opaque path
     nntp - doesn't constrain path
-
- -
$Id$
- - \ No newline at end of file diff --git a/docs/index.html b/docs/index.html index 4492389f..7a7ec0a3 100644 --- a/docs/index.html +++ b/docs/index.html @@ -42,9 +42,6 @@ conventions.

-
Code Quality Issues
-
Discusses code quality issues and places that need to be refactored.
-
Implementation Progress
Tables detailing HTML element and CSS property implementation coverage.
@@ -105,6 +102,12 @@ the code. They may be upgraded to HTML files or stay as TXT scratchpads.

Common security issues that may still arise (half-baked). + + Development + Code Quality Issues + Enumerates code quality issues and places that need to be refactored. + + Proposal Filter levels