mirror of
https://github.com/ezyang/htmlpurifier.git
synced 2025-01-03 13:21:51 +00:00
[1.2.0] HTML-ization for code-quality and colors. Also added in missing $Id$ to progress, and allowed for subtitling in the style.
git-svn-id: http://htmlpurifier.org/svnroot/htmlpurifier/trunk@533 48356398-32a2-884e-a903-53898d9a118a
This commit is contained in:
Edward Z. Yang
parent
780c7fd309
commit
90dd7f13ae
@ -1,12 +1,24 @@
|
|||||||
|
<?xml version="1.0" encoding="UTF-8"?>
|
||||||
|
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
|
||||||
|
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
|
||||||
|
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en"><head>
|
||||||
|
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
|
||||||
|
<meta name="description" content="Discusses code quality issues in HTML Purifier." />
|
||||||
|
<link rel="stylesheet" type="text/css" href="./style.css" />
|
||||||
|
|
||||||
Code Quality Issues
|
<title>Code Quality Issues - HTML Purifier End-User Documentation</title>
|
||||||
|
|
||||||
Okay, face it. Programmers can get lazy, cut corners, or make mistakes. They
|
</head><body>
|
||||||
|
|
||||||
|
<h1>Code Quality Issues</h1>
|
||||||
|
|
||||||
|
<p>Okay, face it. Programmers can get lazy, cut corners, or make mistakes. They
|
||||||
also can do quick prototypes, and then forget to rewrite them later. Well,
|
also can do quick prototypes, and then forget to rewrite them later. Well,
|
||||||
while I can't list mistakes in here, I can list prototype-like segments
|
while I can't list mistakes in here, I can list prototype-like segments
|
||||||
of code that should be aggressively refactored. This does not list
|
of code that should be aggressively refactored. This does not list
|
||||||
optimization issues, that needs to be done after intense profiling.
|
optimization issues, that needs to be done after intense profiling.</p>
|
||||||
|
|
||||||
|
<pre>
|
||||||
AttrDef
|
AttrDef
|
||||||
Class - doesn't support Unicode characters (fringe); uses regular
|
Class - doesn't support Unicode characters (fringe); uses regular
|
||||||
expressions
|
expressions
|
||||||
@ -26,5 +38,8 @@ URIScheme - needs to have callable generic checks
|
|||||||
mailto - doesn't validate emails, doesn't validate querystring
|
mailto - doesn't validate emails, doesn't validate querystring
|
||||||
news - doesn't validate opaque path
|
news - doesn't validate opaque path
|
||||||
nntp - doesn't constrain path
|
nntp - doesn't constrain path
|
||||||
EOL
|
</pre>
|
||||||
|
|
||||||
|
<div id="version">$Id$</div>
|
||||||
|
|
||||||
|
</body></html>
|
||||||
44
docs/colors.html
Normal file
44
docs/colors.html
Normal file
@ -0,0 +1,44 @@
|
|||||||
|
<?xml version="1.0" encoding="UTF-8"?>
|
||||||
|
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
|
||||||
|
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
|
||||||
|
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en"><head>
|
||||||
|
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
|
||||||
|
<meta name="description" content="Proposal to allow for color contraints in HTML Purifier." />
|
||||||
|
<link rel="stylesheet" type="text/css" href="./style.css" />
|
||||||
|
|
||||||
|
<title>Proposal: Colors - HTML Purifier Proposal</title>
|
||||||
|
|
||||||
|
</head><body>
|
||||||
|
|
||||||
|
<h1 class="subtitled">Proposal: Colors</h1>
|
||||||
|
<div class="subtitle">Hammering some sense into those color-blind newbies</div>
|
||||||
|
|
||||||
|
<p>Your website probably has a color-scheme.
|
||||||
|
<span style="color:#090; background:#FFF;">Green on white</span>,
|
||||||
|
<span style="color:#A0F; background:#FF0;">purple on yellow</span>,
|
||||||
|
whatever. When you give users the ability to style their content, you may
|
||||||
|
want them to keep in line with your styling. If you're website is all
|
||||||
|
about light colors, you don't want a user to come in and vandalize your
|
||||||
|
page with a deep maroon.</p>
|
||||||
|
|
||||||
|
<p>This is an extremely silly feature proposal, but I'm writing it down anyway.</p>
|
||||||
|
|
||||||
|
<p>What if the user could constrain the colors specified in inline styles? You
|
||||||
|
are only allowed to use these shades of dark green for text and these shades
|
||||||
|
of light yellow for the background. At the very least, you could ensure
|
||||||
|
that we did not have pale yellow on white text.</p>
|
||||||
|
|
||||||
|
<h2>Implementation issues</h2>
|
||||||
|
|
||||||
|
<ol>
|
||||||
|
<li>Requires the color attribute definition to know, currently, what the text
|
||||||
|
and background colors are. This becomes difficult when classes are thrown
|
||||||
|
into the mix.</li>
|
||||||
|
<li>The user still has to define the permissible colors, how does one do
|
||||||
|
something like that?</li>
|
||||||
|
</ol>
|
||||||
|
|
||||||
|
<div id="version">$Id$</div>
|
||||||
|
|
||||||
|
</body>
|
||||||
|
</html>
|
||||||
@ -1,23 +0,0 @@
|
|||||||
|
|
||||||
Colors
|
|
||||||
Hammering some sense into those content-makers
|
|
||||||
|
|
||||||
Your website probably has a color-scheme. Green on white, purple on yellow,
|
|
||||||
whatever. When you give users the ability to style their content, you may
|
|
||||||
want them to keep in line with your styling. If you're website is all
|
|
||||||
about light colors, you don't want a user to come in and vandalize your
|
|
||||||
page with a deep maroon.
|
|
||||||
|
|
||||||
This is an extremely silly feature proposal, but I'm writing it down anyway.
|
|
||||||
|
|
||||||
What if the user could constrain the colors specified in inline styles? You
|
|
||||||
are only allowed to use these shades of dark green for text and these shades
|
|
||||||
of light yellow for the background. At the very least, you could ensure
|
|
||||||
that we did not have pale yellow on white text.
|
|
||||||
|
|
||||||
Implementation issues:
|
|
||||||
1. Requires the color attribute definition to know, currently, what the text
|
|
||||||
and background colors are. This becomes difficult when classes are thrown
|
|
||||||
into the mix.
|
|
||||||
2. The user still has to define the permissible colors, how does one do
|
|
||||||
something like that?
|
|
||||||
@ -292,4 +292,6 @@ Mozilla on inside and needs -moz-outline, no IE support.</td></tr>
|
|||||||
|
|
||||||
</table>
|
</table>
|
||||||
|
|
||||||
|
<div id="version">$Id$</div>
|
||||||
|
|
||||||
</body></html>
|
</body></html>
|
||||||
@ -12,6 +12,11 @@ h2 {border-bottom:1px solid #CCC; font-family:sans-serif; font-weight:normal;
|
|||||||
h3 {font-family:sans-serif; font-size:1.1em; font-weight:bold; }
|
h3 {font-family:sans-serif; font-size:1.1em; font-weight:bold; }
|
||||||
h4 {font-family:sans-serif; font-size:0.9em; font-weight:bold; }
|
h4 {font-family:sans-serif; font-size:0.9em; font-weight:bold; }
|
||||||
|
|
||||||
|
/* For witty quips */
|
||||||
|
.subtitled {margin-bottom:0em;}
|
||||||
|
.subtitle {font-size:.8em; margin-bottom:1em; text-align:center;
|
||||||
|
font-style:italic; margin-top:-.2em;}
|
||||||
|
|
||||||
/* Used for special "See also" links. */
|
/* Used for special "See also" links. */
|
||||||
.reference {font-style:italic;margin-left:2em;}
|
.reference {font-style:italic;margin-left:2em;}
|
||||||
|
|
||||||
@ -25,4 +30,4 @@ h4 {font-family:sans-serif; font-size:0.9em; font-weight:bold; }
|
|||||||
.table tbody td {border-bottom:1px solid #CCC; padding-right:0.6em;padding-left:0.6em;}
|
.table tbody td {border-bottom:1px solid #CCC; padding-right:0.6em;padding-left:0.6em;}
|
||||||
|
|
||||||
/* Contains, without exception, $Id$, for SVN version info. */
|
/* Contains, without exception, $Id$, for SVN version info. */
|
||||||
#version {text-align:right; font-style:italic; }
|
#version {text-align:right; font-style:italic; margin:2em 0;}
|
||||||
Loading…
Reference in New Issue
Block a user