mirrors/htmlpurifier
0
0
Fork 0
mirror of https://github.com/ezyang/htmlpurifier.git synced 2024-12-22 16:31:53 +00:00
Code Releases Activity

Don't suggest chmod to 777 (#373)

Browse Source 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>
This commit is contained in:
Edward Z. Yang 2023-04-30 13:55:11 -04:00 committed by GitHub
parent 43f49ac9a5
commit 6eb6123036
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
library/HTMLPurifier/DefinitionCache/Serializer.php
View File

@ -287,13 +287,14 @@ class HTMLPurifier_DefinitionCache_Serializer extends HTMLPurifier_DefinitionCac
} elseif (filegroup($dir) === posix_getgid()) { } elseif (filegroup($dir) === posix_getgid()) {
$chmod = $chmod | 0070; $chmod = $chmod | 0070;
} else { } else {
// PHP's probably running as nobody, so we'll // PHP's probably running as nobody, it is
// need to give global permissions // not obvious how to fix this (777 is probably
$chmod = $chmod | 0777; // bad if you are multi-user), let the user figure it out
$chmod = null;
} }
trigger_error( trigger_error(
'Directory ' . $dir . ' not writable, ' . 'Directory ' . $dir . ' not writable. ' .
'please chmod to ' . decoct($chmod), ($chmod === null ? '' : 'Please chmod to ' . decoct($chmod)),
E_USER_WARNING E_USER_WARNING
); );
} else { } else {