From 3fc193c7553ca9eb3431a48708c17ad081cc1e64 Mon Sep 17 00:00:00 2001 From: Kieran Date: Mon, 27 Jun 2022 22:20:36 +0100 Subject: [PATCH] Fix #322 - PHP 8.1 deprecation notice in HostBlacklist URIFilter (#323) --- library/HTMLPurifier/URIFilter/HostBlacklist.php | 2 +- tests/HTMLPurifier/URIFilter/HostBlacklistTest.php | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/library/HTMLPurifier/URIFilter/HostBlacklist.php b/library/HTMLPurifier/URIFilter/HostBlacklist.php index a6645c17..32197c0e 100644 --- a/library/HTMLPurifier/URIFilter/HostBlacklist.php +++ b/library/HTMLPurifier/URIFilter/HostBlacklist.php @@ -35,7 +35,7 @@ class HTMLPurifier_URIFilter_HostBlacklist extends HTMLPurifier_URIFilter public function filter(&$uri, $config, $context) { foreach ($this->blacklist as $blacklisted_host_fragment) { - if (strpos($uri->host, $blacklisted_host_fragment) !== false) { + if ($uri->host !== null && strpos($uri->host, $blacklisted_host_fragment) !== false) { return false; } } diff --git a/tests/HTMLPurifier/URIFilter/HostBlacklistTest.php b/tests/HTMLPurifier/URIFilter/HostBlacklistTest.php index ffbff0c5..62a1cefd 100644 --- a/tests/HTMLPurifier/URIFilter/HostBlacklistTest.php +++ b/tests/HTMLPurifier/URIFilter/HostBlacklistTest.php @@ -28,6 +28,12 @@ class HTMLPurifier_URIFilter_HostBlacklistTest extends HTMLPurifier_URIFilterHar $this->assertFiltering('http://google.com'); } + public function testFragment() + { + $this->config->set('URI.HostBlacklist', 'example.com'); + $this->assertFiltering('#foo'); + } + } // vim: et sw=4 sts=4