[1.6.1] Activate transform for hr.size

git-svn-id: http://htmlpurifier.org/svnroot/htmlpurifier/trunk@1006 48356398-32a2-884e-a903-53898d9a118a

NEWS

@@ -19,6 +19,7 @@ NEWS ( CHANGELOG and HISTORY )                                     HTMLPurifier
   images will hang around with an empty src
 ! Support for more deprecated attributes via transformations:
   + hspace and vspace in img
+  + size in hr
 ! target attribute in a tag supported, use %Attr.AllowedFrameTargets
   to enable
 - Possibly fatal bug with __autoload() fixed in module manager

TODO

@@ -9,7 +9,7 @@ TODO List
 
 1.6.1 [Oh Dear, We Missed Something!]
  # align in img and table
- # noshade and size in hr
+ # noshade in hr
 
 1.7 release [Advanced API]
  # Complete advanced API, and fully document it

docs/dev-progress.html

@@ -283,7 +283,7 @@ Mozilla on inside and needs -moz-outline, no IE support.</td></tr>
     <tr class="impl-yes"><td>A</td><td>Turn into ID</td></tr>
 <tr><td>noshade</td><td>HR</td><td>Boolean, style 'border-style:solid;'</td></tr>
 <tr><td>nowrap</td><td>TD, TH</td><td>Boolean, style 'white-space:nowrap;' (not compat with IE5)</td></tr>
-<tr><td>size</td><td>HR</td><td>Near-equiv 'height', needs px suffix if original was pixels</td></tr>
+<tr class="impl-yes"><td>size</td><td>HR</td><td>Near-equiv 'height', needs px suffix if original was pixels</td></tr>
 <tr class="required impl-yes"><td>src</td><td>IMG</td><td>Required, insert blank or default img if not set</td></tr>
 <tr class="impl-yes"><td>start</td><td>OL</td><td>Poorly supported 'counter-reset', allowed in loose, dropped in strict</td></tr>
 <tr><td rowspan="3">type</td><td>LI</td><td rowspan="3">Equivalent style 'list-style-type', different allowed values though. (needs testing)</td></tr>

library/HTMLPurifier/HTMLModule/TransformToStrict.php

@@ -99,6 +99,8 @@ class HTMLPurifier_HTMLModule_TransformToStrict extends HTMLPurifier_HTMLModule
         $this->info['img']->attr_transform_pre['hspace'] = new HTMLPurifier_AttrTransform_ImgSpace('hspace');
         $this->info['img']->attr_transform_pre['vspace'] = new HTMLPurifier_AttrTransform_ImgSpace('vspace');
         
+        $this->info['hr']->attr_transform_pre['size'] = new HTMLPurifier_AttrTransform_Length('size', 'height');
+        
     }
     
     var $defines_child_def = true;

tests/HTMLPurifier/Strategy/ValidateAttributesTest.php

@@ -214,6 +214,13 @@ class HTMLPurifier_Strategy_ValidateAttributesTest extends
             '<a href="foo" />',
             array('Attr.AllowedFrameTargets' => '_top', 'HTML.Strict' => true)
         );
+        
+        // hr rule transformations
+        $this->assertResult(
+            '<hr size="3" />',
+            '<hr style="height:3px;" />'
+        );
+        
     }
     
 }