mirror of
https://git.zx2c4.com/cgit
synced 2024-11-22 08:28:42 +00:00
a1429dbc89
The current 'clone-prefix' setting has some known issues: * All repos get the same 'clone-prefix' value since the setting is not adopted during repo registration (in cgitrc, or during scan-path traversal), but only when the setting is used. * The generated clone-urls for a repo is a combination of 'clone-prefix', a slash and the repo url. This doesn't work well with e.g. ssh-style urls like 'git@example.org:repo.git', since the inserted slash will make the repo relative to the filesystem root. * If 'remove-suffix' is enabled, the generated clone-urls will not work for cloning (except for http-urls to cgit itself) since they miss the '.git' suffix. The new 'clone-url' setting is designed to avoid the mentioned issues: * Each repo adopts the default 'clone-url' when the repo is defined. This allows different groups of repos to adopt different values. * The clone-urls for a repo is generated by expanding environment variables in a string template without inserting arbitrary characters, hence any kind of clone-url can be generated. * Macro expansion also eases the 'remove-suffix' pain since it's now possible to define e.g. 'clone-url=git://foo.org/$CGIT_REPO_URL.git' for a set of repos. A furter improvement would be to define e.g. $CGIT_REPO_SUFFIX to '.git' for all repos which had their url prettified, or to store the original $CGIT_REPO_URL in e.g. $CGIT_REPO_REAL_URL before suffix removal. Reviewed-by: Ferry Huberts <mailings@hupie.com> Signed-off-by: Lars Hjemli <hjemli@gmail.com> |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| Makefile | ||
| setup.sh | ||
| t0010-validate-html.sh | ||
| t0020-validate-cache.sh | ||
| t0101-index.sh | ||
| t0102-summary.sh | ||
| t0103-log.sh | ||
| t0104-tree.sh | ||
| t0105-commit.sh | ||
| t0106-diff.sh | ||
| t0107-snapshot.sh | ||
| t0108-patch.sh | ||