mirrors/cgit
0
0
Fork 0
mirror of https://git.zx2c4.com/cgit synced 2024-11-26 02:18:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

ui-shared: don't print path crumbs without a repo

Browse Source 
cgit_print_path_crumbs() can call repolink() which assumes that ctx.repo
is non-null.  Currently we don't have any commands that set want_vpath
without also setting want_repo so it shouldn't be possible to fail this
test, but the check in cgit.c is in the wrong order so it is possible to
specify a query string like "?p=log&path=foo/bar" to end up here without
a valid repository.

This was found by American fuzzy lop [0].

[0] http://lcamtuf.coredump.cx/afl/

Signed-off-by: John Keeping <john@keeping.me.uk>
This commit is contained in:
John Keeping 2017-02-19 12:27:48 +00:00 committed by Lukas Fleischer
parent 67e2b69ec9
commit fdcd7dc818
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ui-shared.c
View File

@ -1039,7 +1039,7 @@ void cgit_print_pageheader(void)
free(currenturl); free(currenturl);
} }
html("</td></tr></table>\n"); html("</td></tr></table>\n");
if (ctx.env.authenticated && ctx.qry.vpath) { if (ctx.env.authenticated && ctx.repo && ctx.qry.vpath) {
html("<div class='path'>"); html("<div class='path'>");
html("path: "); html("path: ");
cgit_print_path_crumbs(ctx.qry.vpath); cgit_print_path_crumbs(ctx.qry.vpath);