Handle missing timestamp in commit/tag objects

When a commit or tag lacks author/committer/tagger timestamp, do not skip
the next line in the commit/tag object.

Also, do not bother to print timestamps with value 0 as it is close to certain
to be bogus.

Signed-off-by: Lars Hjemli <hjemli@gmail.com>
This commit is contained in:
Lars Hjemli 2007-12-02 22:11:35 +01:00
parent 5b75064a81
commit fc4c4ba3a9
2 changed files with 7 additions and 3 deletions

View File

@ -218,7 +218,7 @@ struct commitinfo *cgit_parse_commit(struct commit *commit)
p = t; p = t;
t = strchr(t, '>') + 1; t = strchr(t, '>') + 1;
ret->author_email = substr(p, t); ret->author_email = substr(p, t);
ret->author_date = atol(++t); ret->author_date = atol(t+1);
p = strchr(t, '\n') + 1; p = strchr(t, '\n') + 1;
} }
@ -229,7 +229,7 @@ struct commitinfo *cgit_parse_commit(struct commit *commit)
p = t; p = t;
t = strchr(t, '>') + 1; t = strchr(t, '>') + 1;
ret->committer_email = substr(p, t); ret->committer_email = substr(p, t);
ret->committer_date = atol(++t); ret->committer_date = atol(t+1);
p = strchr(t, '\n') + 1; p = strchr(t, '\n') + 1;
} }
@ -290,7 +290,7 @@ struct taginfo *cgit_parse_tag(struct tag *tag)
p = t; p = t;
t = strchr(t, '>') + 1; t = strchr(t, '>') + 1;
ret->tagger_email = substr(p, t); ret->tagger_email = substr(p, t);
ret->tagger_date = atol(++t); ret->tagger_date = atol(t+1);
} }
p = strchr(p, '\n') + 1; p = strchr(p, '\n') + 1;
} }

View File

@ -304,6 +304,8 @@ void cgit_print_date(time_t secs, char *format)
char buf[64]; char buf[64];
struct tm *time; struct tm *time;
if (!secs)
return;
time = gmtime(&secs); time = gmtime(&secs);
strftime(buf, sizeof(buf)-1, format, time); strftime(buf, sizeof(buf)-1, format, time);
html_txt(buf); html_txt(buf);
@ -313,6 +315,8 @@ void cgit_print_age(time_t t, time_t max_relative, char *format)
{ {
time_t now, secs; time_t now, secs;
if (!t)
return;
time(&now); time(&now);
secs = now - t; secs = now - t;