mirrors/cgit
0
0
Fork 0
mirror of https://git.zx2c4.com/cgit synced 2024-11-22 08:28:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

ui-tag: clean up taginfo

Browse Source 
Free the taginfo when we're done with it.  Also reduce the scope of a
couple of variables so that it's clear that this is the only path that
uses the taginfo structure.

Coverity-Id: 141883
Signed-off-by: John Keeping <john@keeping.me.uk>
This commit is contained in:
John Keeping 2016-08-13 11:53:24 +01:00
parent b19d889f6c
commit f80b73fa20
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ui-tag.c
View File

@ -44,8 +44,6 @@ void cgit_print_tag(char *revname)
struct strbuf fullref = STRBUF_INIT; struct strbuf fullref = STRBUF_INIT;
unsigned char sha1[20]; unsigned char sha1[20];
struct object *obj; struct object *obj;
struct tag *tag;
struct taginfo *info;
if (!revname) if (!revname)
revname = ctx.qry.head; revname = ctx.qry.head;
@ -63,6 +61,9 @@ void cgit_print_tag(char *revname)
goto cleanup; goto cleanup;
} }
if (obj->type == OBJ_TAG) { if (obj->type == OBJ_TAG) {
struct tag *tag;
struct taginfo *info;
tag = lookup_tag(sha1); tag = lookup_tag(sha1);
if (!tag || parse_tag(tag) || !(info = cgit_parse_tag(tag))) { if (!tag || parse_tag(tag) || !(info = cgit_parse_tag(tag))) {
cgit_print_error_page(500, "Internal server error", cgit_print_error_page(500, "Internal server error",
@ -99,6 +100,7 @@ void cgit_print_tag(char *revname)
html("</table>\n"); html("</table>\n");
print_tag_content(info->msg); print_tag_content(info->msg);
cgit_print_layout_end(); cgit_print_layout_end();
cgit_free_taginfo(info);
} else { } else {
cgit_print_layout_start(); cgit_print_layout_start();
html("<table class='commit-info'>\n"); html("<table class='commit-info'>\n");