mirror of
https://git.zx2c4.com/cgit
synced 2024-11-08 09:38:41 +00:00
ui-shared: make a char* parameter const
All cgit_xxx_link functions take const char* for the 'name' parameter, except for cgit_commit_link, which takes a char* and subsequently modifies the contents. Avoiding the content changes, and making it const char* will avoid the need to make copies of const char* strings being passed to cgit_commit_link. Signed-off-by: Jeff Smith <whydoubt@gmail.com> Reviewed-by: John Keeping <john@keeping.me.uk>
This commit is contained in:
parent
9337c7ee83
commit
f6ffe40d1a
19
ui-shared.c
19
ui-shared.c
@ -347,18 +347,11 @@ void cgit_log_link(const char *name, const char *title, const char *class,
|
||||
html("</a>");
|
||||
}
|
||||
|
||||
void cgit_commit_link(char *name, const char *title, const char *class,
|
||||
void cgit_commit_link(const char *name, const char *title, const char *class,
|
||||
const char *head, const char *rev, const char *path)
|
||||
{
|
||||
char *delim;
|
||||
|
||||
if (strlen(name) > ctx.cfg.max_msg_len && ctx.cfg.max_msg_len >= 15) {
|
||||
name[ctx.cfg.max_msg_len] = '\0';
|
||||
name[ctx.cfg.max_msg_len - 1] = '.';
|
||||
name[ctx.cfg.max_msg_len - 2] = '.';
|
||||
name[ctx.cfg.max_msg_len - 3] = '.';
|
||||
}
|
||||
|
||||
delim = repolink(title, class, "commit", head, path);
|
||||
if (rev && ctx.qry.head && strcmp(rev, ctx.qry.head)) {
|
||||
html(delim);
|
||||
@ -387,9 +380,13 @@ void cgit_commit_link(char *name, const char *title, const char *class,
|
||||
html("follow=1");
|
||||
}
|
||||
html("'>");
|
||||
if (name[0] != '\0')
|
||||
html_txt(name);
|
||||
else
|
||||
if (name[0] != '\0') {
|
||||
if (strlen(name) > ctx.cfg.max_msg_len && ctx.cfg.max_msg_len >= 15) {
|
||||
html_ntxt(name, ctx.cfg.max_msg_len - 3);
|
||||
html("...");
|
||||
} else
|
||||
html_txt(name);
|
||||
} else
|
||||
html_txt("(no commit message)");
|
||||
html("</a>");
|
||||
}
|
||||
|
@ -30,7 +30,7 @@ extern void cgit_log_link(const char *name, const char *title,
|
||||
const char *class, const char *head, const char *rev,
|
||||
const char *path, int ofs, const char *grep,
|
||||
const char *pattern, int showmsg, int follow);
|
||||
extern void cgit_commit_link(char *name, const char *title,
|
||||
extern void cgit_commit_link(const char *name, const char *title,
|
||||
const char *class, const char *head,
|
||||
const char *rev, const char *path);
|
||||
extern void cgit_patch_link(const char *name, const char *title,
|
||||
|
Loading…
Reference in New Issue
Block a user