mirrors/cgit
0
0
Fork 0
mirror of https://git.zx2c4.com/cgit synced 2024-11-10 02:28:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

ui-shared: pass separator in to cgit_print_snapshot_links()

Browse Source 
cgit_print_snapshot_links() is almost identical to
print_tag_downloads(), so let's extract the difference to a parameter in
preparation for removing print_tag_downloads() in the next commit.

Signed-off-by: John Keeping <john@keeping.me.uk>
Reviewed-by: Christian Hesse <mail@eworm.de>
This commit is contained in:
John Keeping 2018-03-31 15:08:59 +01:00 committed by Jason A. Donenfeld
parent 5b1f42ffee
commit e491eaa5df
4 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ui-commit.c
View File

@ -110,7 +110,7 @@ void cgit_print_commit(char *hex, const char *prefix)
} }
if (ctx.repo->snapshots) { if (ctx.repo->snapshots) {
html("<tr><th>download</th><td colspan='2' class='sha1'>"); html("<tr><th>download</th><td colspan='2' class='sha1'>");
cgit_print_snapshot_links(ctx.repo, hex); cgit_print_snapshot_links(ctx.repo, hex, "<br/>");
html("</td></tr>"); html("</td></tr>");
} }
html("</table>\n"); html("</table>\n");

5
ui-shared.c
View File

@ -1111,7 +1111,8 @@ void cgit_compose_snapshot_prefix(struct strbuf *filename, const char *base,
strbuf_addf(filename, "%s-%s", base, ref); strbuf_addf(filename, "%s-%s", base, ref);
} }
void cgit_print_snapshot_links(const struct cgit_repo *repo, const char *ref) void cgit_print_snapshot_links(const struct cgit_repo *repo, const char *ref,
const char *separator)
{ {
const struct cgit_snapshot_format* f; const struct cgit_snapshot_format* f;
struct strbuf filename = STRBUF_INIT; struct strbuf filename = STRBUF_INIT;
@ -1132,7 +1133,7 @@ void cgit_print_snapshot_links(const struct cgit_repo *repo, const char *ref)
strbuf_addstr(&filename, f->suffix); strbuf_addstr(&filename, f->suffix);
cgit_snapshot_link(filename.buf, NULL, NULL, NULL, NULL, cgit_snapshot_link(filename.buf, NULL, NULL, NULL, NULL,
filename.buf); filename.buf);
html("<br/>"); html(separator);
} }
strbuf_release(&filename); strbuf_release(&filename);
} }

2
ui-shared.h
View File

@ -77,7 +77,7 @@ extern void cgit_print_filemode(unsigned short mode);
extern void cgit_compose_snapshot_prefix(struct strbuf *filename, extern void cgit_compose_snapshot_prefix(struct strbuf *filename,
const char *base, const char *ref); const char *base, const char *ref);
extern void cgit_print_snapshot_links(const struct cgit_repo *repo, extern void cgit_print_snapshot_links(const struct cgit_repo *repo,
const char *ref); const char *ref, const char *separator);
extern const char *cgit_snapshot_prefix(const struct cgit_repo *repo); extern const char *cgit_snapshot_prefix(const struct cgit_repo *repo);
extern void cgit_add_hidden_formfields(int incl_head, int incl_search, extern void cgit_add_hidden_formfields(int incl_head, int incl_search,
const char *page); const char *page);

2
ui-tag.c
View File

@ -34,7 +34,7 @@ static void print_tag_content(char *buf)
static void print_download_links(char *revname) static void print_download_links(char *revname)
{ {
html("<tr><th>download</th><td class='sha1'>"); html("<tr><th>download</th><td class='sha1'>");
cgit_print_snapshot_links(ctx.repo, revname); cgit_print_snapshot_links(ctx.repo, revname, "<br/>");
html("</td></tr>"); html("</td></tr>");
} }