mirrors/cgit
0
0
Fork 0
mirror of https://git.zx2c4.com/cgit synced 2024-11-25 01:48:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

auth: lua string comparisons are time invariant

Browse Source 
By default, strings are compared by hash, so we can remove this comment.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
This commit is contained in:
Jason A. Donenfeld 2014-01-16 19:47:35 +01:00
parent b826537cb4
commit df00ab1096
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
filters/simple-authentication.lua
View File

@ -45,7 +45,7 @@ function authenticate_post()
redirect_to(redirect) redirect_to(redirect)
-- TODO: Implement time invariant string comparison function to mitigate timing attack. -- Lua hashes strings, so these comparisons are time invariant.
if password == nil or password ~= post["password"] then if password == nil or password ~= post["password"] then
set_cookie("cgitauth", "") set_cookie("cgitauth", "")
else else
@ -222,7 +222,7 @@ function validate_value(cookie)
return nil return nil
end end
-- TODO: implement time invariant comparison to prevent against timing attack. -- Lua hashes strings, so these comparisons are time invariant.
if hmac ~= crypto.hmac.digest("sha1", value .. "|" .. tostring(expiration) .. "|" .. salt, secret) then if hmac ~= crypto.hmac.digest("sha1", value .. "|" .. tostring(expiration) .. "|" .. salt, secret) then
return nil return nil
end end