mirror of
https://git.zx2c4.com/cgit
synced 2024-11-09 10:08:42 +00:00
ui-diff: don't link to single file diff stat
Seeing the diff stat for a single file is pretty useless, so reset the diff type before generating the links to individual files in the diff stat so that the links will show a useful diff. Reported-by: Konstantin Ryabitsev <mricon@kernel.org> Signed-off-by: John Keeping <john@keeping.me.uk>
This commit is contained in:
parent
7552266aac
commit
d6c4050771
10
ui-diff.c
10
ui-diff.c
@ -428,6 +428,16 @@ void cgit_print_diff(const char *new_rev, const char *old_rev,
|
||||
if (show_ctrls)
|
||||
cgit_print_diff_ctrls();
|
||||
|
||||
/*
|
||||
* Clicking on a link to a file in the diff stat should show a diff
|
||||
* of the file, showing the diff stat limited to a single file is
|
||||
* pretty useless. All links from this point on will be to
|
||||
* individual files, so we simply reset the difftype in the query
|
||||
* here to avoid propagating DIFF_STATONLY to the individual files.
|
||||
*/
|
||||
if (difftype == DIFF_STATONLY)
|
||||
ctx.qry.difftype = ctx.cfg.difftype;
|
||||
|
||||
cgit_print_diffstat(old_rev_sha1, new_rev_sha1, prefix);
|
||||
|
||||
if (difftype == DIFF_STATONLY)
|
||||
|
Loading…
Reference in New Issue
Block a user