mirrors/cgit
0
0
Fork 0
mirror of https://git.zx2c4.com/cgit synced 2024-11-22 08:28:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

cgit_parse_commit(): Add missing call to xstrdup()

Browse Source 
It's rather silly to point into random memory-locations. Also, remove a
call to strdup() used on a literal char *.

Signed-off-by: Lars Hjemli <hjemli@gmail.com>
This commit is contained in:
Lars Hjemli 2007-10-27 13:50:18 +02:00
parent 13d2b0b25c
commit c61360fea0
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
parsing.c
View File

@ -242,14 +242,14 @@ struct commitinfo *cgit_parse_commit(struct commit *commit)
t = strchr(p, '\n'); t = strchr(p, '\n');
if (t) { if (t) {
if (*t == '\0') if (*t == '\0')
ret->subject = strdup("** empty **"); ret->subject = "** empty **";
else else
ret->subject = substr(p, t); ret->subject = substr(p, t);
p = t + 1; p = t + 1;
while (*p == '\n') while (*p == '\n')
p = strchr(p, '\n') + 1; p = strchr(p, '\n') + 1;
ret->msg = p; ret->msg = xstrdup(p);
} else } else
ret->subject = substr(p, p+strlen(p)); ret->subject = substr(p, p+strlen(p));