ui: Remember to print ampersand as proper html entities.

This commit is contained in:
William Bell 2012-10-09 20:45:58 +02:00 committed by Jason A. Donenfeld
parent fdfb6a6d80
commit c366bd6fa8
2 changed files with 8 additions and 8 deletions

View File

@ -104,7 +104,7 @@ void print_sort_header(const char *title, const char *sort)
{ {
htmlf("<th class='left'><a href='%s?s=%s", cgit_rooturl(), sort); htmlf("<th class='left'><a href='%s?s=%s", cgit_rooturl(), sort);
if (ctx.qry.search) { if (ctx.qry.search) {
html("&q="); html("&amp;q=");
html_url_arg(ctx.qry.search); html_url_arg(ctx.qry.search);
} }
htmlf("'>%s</a></th>", title); htmlf("'>%s</a></th>", title);

View File

@ -83,7 +83,7 @@ char *cgit_fileurl(const char *reponame, const char *pagename,
} else { } else {
tmp = fmt("?url=%s/%s/%s", reponame, pagename, tmp = fmt("?url=%s/%s/%s", reponame, pagename,
(filename ? filename : "")); (filename ? filename : ""));
delim = "&"; delim = "&amp;";
} }
if (query) if (query)
tmp = fmt("%s%s%s", tmp, delim, query); tmp = fmt("%s%s%s", tmp, delim, query);
@ -146,19 +146,19 @@ static void site_url(const char *page, const char *search, const char *sort, int
if (page) { if (page) {
htmlf("?p=%s", page); htmlf("?p=%s", page);
delim = "&"; delim = "&amp;";
} }
if (search) { if (search) {
html(delim); html(delim);
html("q="); html("q=");
html_attr(search); html_attr(search);
delim = "&"; delim = "&amp;";
} }
if (sort) { if (sort) {
html(delim); html(delim);
html("s="); html("s=");
html_attr(sort); html_attr(sort);
delim = "&"; delim = "&amp;";
} }
if (ofs) { if (ofs) {
html(delim); html(delim);
@ -298,13 +298,13 @@ void cgit_log_link(const char *name, const char *title, const char *class,
html(delim); html(delim);
html("id="); html("id=");
html_url_arg(rev); html_url_arg(rev);
delim = "&"; delim = "&amp;";
} }
if (grep && pattern) { if (grep && pattern) {
html(delim); html(delim);
html("qt="); html("qt=");
html_url_arg(grep); html_url_arg(grep);
delim = "&"; delim = "&amp;";
html(delim); html(delim);
html("q="); html("q=");
html_url_arg(pattern); html_url_arg(pattern);
@ -313,7 +313,7 @@ void cgit_log_link(const char *name, const char *title, const char *class,
html(delim); html(delim);
html("ofs="); html("ofs=");
htmlf("%d", ofs); htmlf("%d", ofs);
delim = "&"; delim = "&amp;";
} }
if (showmsg) { if (showmsg) {
html(delim); html(delim);