mirrors/cgit
0
0
Fork 0
mirror of https://git.zx2c4.com/cgit synced 2024-11-26 02:18:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

ui-clone.c: Fix path check

Browse Source 
The starts_with() check was broken in two ways: For one thing, the
parameters were passed in the wrong order, for another thing,
starts_with() returns 1 if the string starts with the prefix (not 0).

Note that this bug existed since commit 02a545e (Add support for cloning
over http, 2008-08-06) but only pops in in corner cases.

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
This commit is contained in:
Lukas Fleischer 2015-02-09 07:25:00 +01:00 committed by Jason A. Donenfeld
parent 7358f63015
commit b66b16ed02
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ui-clone.c
View File

@ -63,8 +63,8 @@ static void send_file(char *path)
} }
ctx.page.mimetype = "application/octet-stream"; ctx.page.mimetype = "application/octet-stream";
ctx.page.filename = path; ctx.page.filename = path;
if (!starts_with(ctx.repo->path, path)) skip_prefix(path, ctx.repo->path, &ctx.page.filename);
ctx.page.filename += strlen(ctx.repo->path) + 1; skip_prefix(ctx.page.filename, "/", &ctx.page.filename);
cgit_print_http_headers(); cgit_print_http_headers();
html_include(path); html_include(path);
} }