mirrors/cgit
0
0
Fork 0
mirror of https://git.zx2c4.com/cgit synced 2024-11-26 02:18:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Properly escape ampersands inside HTML attributes

Browse Source 
Ampersands ("&") appearing inside HTML attributes need to be translated
to "&". Otherwise, invalid XHTML will be generated at various
places, such as at tree views containing links to submodules.

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
This commit is contained in:
Lukas Fleischer 2011-05-24 20:38:40 +02:00 committed by Lars Hjemli
parent ec79265f20
commit 69382320d9
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
html.c
View File

@ -138,7 +138,7 @@ void html_attr(const char *txt)
const char *t = txt; const char *t = txt;
while(t && *t){ while(t && *t){
int c = *t; int c = *t;
if (c=='<' || c=='>' || c=='\'' || c=='\"') { if (c=='<' || c=='>' || c=='\'' || c=='\"' || c=='&') {
html_raw(txt, t - txt); html_raw(txt, t - txt);
if (c=='>') if (c=='>')
html("&gt;"); html("&gt;");
@ -148,6 +148,8 @@ void html_attr(const char *txt)
html("&#x27;"); html("&#x27;");
else if (c=='"') else if (c=='"')
html("&quot;"); html("&quot;");
else if (c=='&')
html("&amp;");
txt = t+1; txt = t+1;
} }
t++; t++;