mirrors/cgit
0
0
Fork 0
mirror of https://git.zx2c4.com/cgit synced 2024-11-26 02:18:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Handle empty/malformed commit messages

Browse Source 
An empty commit message would trigger a segfault in the current
cgit_parse_commit().

Also, make sure that all char-pointers are properly initialized.
This commit is contained in:
Lars Hjemli 2007-01-16 18:41:01 +01:00
parent 5cd2bf7e7f
commit 66091f934a
1 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
parsing.c
View File

@ -145,6 +145,12 @@ struct commitinfo *cgit_parse_commit(struct commit *commit)
ret = xmalloc(sizeof(*ret)); ret = xmalloc(sizeof(*ret));
ret->commit = commit; ret->commit = commit;
ret->author = NULL;
ret->author_email = NULL;
ret->committer = NULL;
ret->committer_email = NULL;
ret->subject = NULL;
ret->msg = NULL;
if (strncmp(p, "tree ", 5)) if (strncmp(p, "tree ", 5))
die("Bad commit: %s", sha1_to_hex(commit->object.sha1)); die("Bad commit: %s", sha1_to_hex(commit->object.sha1));
@ -180,12 +186,13 @@ struct commitinfo *cgit_parse_commit(struct commit *commit)
p = strchr(p, '\n') + 1; p = strchr(p, '\n') + 1;
t = strchr(p, '\n'); t = strchr(p, '\n');
ret->subject = substr(p, t); if (t && *t) {
p = t + 1; ret->subject = substr(p, t);
p = t + 1;
while (*p == '\n')
p = strchr(p, '\n') + 1;
ret->msg = p;
while (*p == '\n')
p = strchr(p, '\n') + 1;
ret->msg = p;
}
return ret; return ret;
} }