mirrors/cgit
0
0
Fork 0
mirror of https://git.zx2c4.com/cgit synced 2024-11-22 08:28:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

cgit.c: Use "else" for mutually exclusive branches

Browse Source 
When parsing command line arguments, no pair of command line options can
ever match simultaneously. Use "else if" blocks to reflect this. This
change improves both readability and speed.

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
This commit is contained in:
Lukas Fleischer 2014-01-10 14:55:30 +01:00 committed by Jason A. Donenfeld
parent e711679618
commit 441e748564
1 changed files with 10 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
cgit.c
View File

@ -865,35 +865,26 @@ static void cgit_parse_args(int argc, const char **argv)
for (i = 1; i < argc; i++) { for (i = 1; i < argc; i++) {
if (!prefixcmp(argv[i], "--cache=")) { if (!prefixcmp(argv[i], "--cache=")) {
ctx.cfg.cache_root = xstrdup(argv[i] + 8); ctx.cfg.cache_root = xstrdup(argv[i] + 8);
} } else if (!strcmp(argv[i], "--nocache")) {
if (!strcmp(argv[i], "--nocache")) {
ctx.cfg.nocache = 1; ctx.cfg.nocache = 1;
} } else if (!strcmp(argv[i], "--nohttp")) {
if (!strcmp(argv[i], "--nohttp")) {
ctx.env.no_http = "1"; ctx.env.no_http = "1";
} } else if (!prefixcmp(argv[i], "--query=")) {
if (!prefixcmp(argv[i], "--query=")) {
ctx.qry.raw = xstrdup(argv[i] + 8); ctx.qry.raw = xstrdup(argv[i] + 8);
} } else if (!prefixcmp(argv[i], "--repo=")) {
if (!prefixcmp(argv[i], "--repo=")) {
ctx.qry.repo = xstrdup(argv[i] + 7); ctx.qry.repo = xstrdup(argv[i] + 7);
} } else if (!prefixcmp(argv[i], "--page=")) {
if (!prefixcmp(argv[i], "--page=")) {
ctx.qry.page = xstrdup(argv[i] + 7); ctx.qry.page = xstrdup(argv[i] + 7);
} } else if (!prefixcmp(argv[i], "--head=")) {
if (!prefixcmp(argv[i], "--head=")) {
ctx.qry.head = xstrdup(argv[i] + 7); ctx.qry.head = xstrdup(argv[i] + 7);
ctx.qry.has_symref = 1; ctx.qry.has_symref = 1;
} } else if (!prefixcmp(argv[i], "--sha1=")) {
if (!prefixcmp(argv[i], "--sha1=")) {
ctx.qry.sha1 = xstrdup(argv[i] + 7); ctx.qry.sha1 = xstrdup(argv[i] + 7);
ctx.qry.has_sha1 = 1; ctx.qry.has_sha1 = 1;
} } else if (!prefixcmp(argv[i], "--ofs=")) {
if (!prefixcmp(argv[i], "--ofs=")) {
ctx.qry.ofs = atoi(argv[i] + 6); ctx.qry.ofs = atoi(argv[i] + 6);
} } else if (!prefixcmp(argv[i], "--scan-tree=") ||
if (!prefixcmp(argv[i], "--scan-tree=") || !prefixcmp(argv[i], "--scan-path=")) {
!prefixcmp(argv[i], "--scan-path=")) {
/* HACK: the global snapshot bitmask defines the /* HACK: the global snapshot bitmask defines the
* set of allowed snapshot formats, but the config * set of allowed snapshot formats, but the config
* file hasn't been parsed yet so the mask is * file hasn't been parsed yet so the mask is