mirrors/cgit
0
0
Fork 0
mirror of https://git.zx2c4.com/cgit synced 2024-11-21 16:08:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix html error detected by test-suite

Browse Source 
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
This commit is contained in:
Lars Hjemli 2007-11-11 13:04:28 +01:00
parent b4649fc905
commit 2915483ef6
11 changed files with 37 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cgit.css
View File

@ -111,7 +111,11 @@ div#sidebar div.infobox {
div#sidebar div.infobox h1 {
font-size: 10pt;
font-weight: bold;
margin: 0px;
margin: 8px 0px 0px 0px;
}
div#sidebar div.infobox h1.first {
margin-top: 0px;
}
div#sidebar div.infobox a.menu {

2
html.c
View File

@ -132,7 +132,7 @@ void html_option(char *value, char *text, char *selected_value)
html_attr(value);
html("'");
if (selected_value && !strcmp(selected_value, value))
html(" selected");
html(" selected='selected'");
html(">");
html_txt(text);
html("</option>\n");

10
tests/t0104-tree.sh
View File

@ -9,7 +9,13 @@ run_test 'find file-1' 'grep -e "file-1" trash/tmp'
run_test 'find file-50' 'grep -e "file-50" trash/tmp'
run_test 'generate bar/tree/file-50' 'cgit_url "bar/tree/file-50" >trash/tmp'
run_test 'find line 1' 'grep -e "<a name=.1.>1</a>" trash/tmp'
run_test 'no line 2' 'grep -ve "<a name=.2.>2</a>" trash/tmp'
run_test 'find line 1' '
grep -e "<a id=.n1. name=.n1. href=.#n1.>1</a>" trash/tmp
'
run_test 'no line 2' '
grep -e "<a id=.n2. name=.n2. href=.#n2.>2</a>" trash/tmp
'
tests_done

2
tests/t0105-commit.sh
View File

@ -13,7 +13,7 @@ run_test 'find commit subject' '
'
run_test 'find commit msg' 'grep -e "<div class=.commit-msg.></div>" trash/tmp'
run_test 'find diffstat' 'grep -e "<table class=.diffstat.>" trash/tmp'
run_test 'find diffstat' 'grep -e "<table summary=.diffstat. class=.diffstat.>" trash/tmp'
run_test 'find diff summary' '
grep -e "1 files changed, 1 insertions, 0 deletions" trash/tmp

6
ui-commit.c
View File

@ -84,7 +84,7 @@ void print_fileinfo(struct fileinfo *info)
html("</td><td class='right'>");
htmlf("%d", info->added + info->removed);
html("</td><td class='graph'>");
htmlf("<table width='%d%%'><tr>", (max_changes > 100 ? 100 : max_changes));
htmlf("<table summary='file diffstat' width='%d%%'><tr>", (max_changes > 100 ? 100 : max_changes));
htmlf("<td class='add' style='width: %.1f%%;'/>",
info->added * 100.0 / max_changes);
htmlf("<td class='rem' style='width: %.1f%%;'/>",
@ -157,7 +157,7 @@ void cgit_print_commit(char *hex)
}
info = cgit_parse_commit(commit);
html("<table class='commit-info'>\n");
html("<table summary='commit info' class='commit-info'>\n");
html("<tr><th>author</th><td>");
html_txt(info->author);
html(" ");
@ -209,7 +209,7 @@ void cgit_print_commit(char *hex)
html("</div>");
if (!(commit->parents && commit->parents->next && commit->parents->next->next)) {
html("<div class='diffstat-header'>Diffstat</div>");
html("<table class='diffstat'>");
html("<table summary='diffstat' class='diffstat'>");
max_changes = 0;
cgit_diff_commit(commit, inspect_filepair);
for(i = 0; i<files; i++)

2
ui-diff.c
View File

@ -141,7 +141,7 @@ void cgit_print_diff(const char *new_rev, const char *old_rev, const char *prefi
if (!commit2 || parse_commit(commit2))
cgit_print_error(fmt("Bad commit: %s", sha1_to_hex(old_rev_sha1)));
}
html("<table class='diff'>");
html("<table summary='diff' class='diff'>");
html("<tr><td>");
cgit_diff_tree(old_rev_sha1, new_rev_sha1, filepair_cb, prefix);
html("</td></tr>");

2
ui-log.c
View File

@ -90,7 +90,7 @@ void cgit_print_log(const char *tip, int ofs, int cnt, char *grep, char *pattern
}
prepare_revision_walk(&rev);
html("<table class='list nowrap'>");
html("<table summary='log' class='list nowrap'>");
html("<tr class='nohover'><th class='left'>Age</th>"
"<th class='left'>Message</th>");

2
ui-repolist.c
View File

@ -53,7 +53,7 @@ void cgit_print_repolist(struct cacheitem *item)
cgit_print_docstart(cgit_root_title, item);
cgit_print_pageheader(cgit_root_title, 0);
html("<table class='list nowrap'>");
html("<table summary='repository list' class='list nowrap'>");
if (cgit_index_header) {
htmlf("<tr class='nohover'><td colspan='%d' class='include-block'>",
columns);

24
ui-shared.c
View File

@ -358,7 +358,7 @@ void cgit_print_docstart(char *title, struct cacheitem *item)
ttl_seconds(item->ttl)));
html("\n");
html(cgit_doctype);
html("<html>\n");
html("<html xmlns='http://www.w3.org/1999/xhtml' xml:lang='en' lang='en'>\n");
html("<head>\n");
html("<title>");
html_txt(title);
@ -373,7 +373,7 @@ void cgit_print_docstart(char *title, struct cacheitem *item)
void cgit_print_docend()
{
html("</td>\n</tr>\n<table>\n</body>\n</html>\n");
html("</td>\n</tr>\n</table>\n</body>\n</html>\n");
}
int print_branch_option(const char *refname, const unsigned char *sha1,
@ -456,21 +456,21 @@ void cgit_print_pageheader(char *title, int show_search)
int header = 0;
html("<div id='sidebar'>\n");
html("<a href='");
html("<div id='logo'><a href='");
html_attr(cgit_rooturl());
htmlf("'><div id='logo'><img src='%s' alt='cgit'/></div></a>\n",
htmlf("'><img src='%s' alt='cgit'/></a></div>\n",
cgit_logo);
html("<div class='infobox'>");
if (cgit_query_repo) {
html("<h1>");
html("<h1 class='first'>");
html_txt(strrpart(cgit_repo->name, 20));
html("</h1>\n");
html_txt(cgit_repo->desc);
if (cgit_repo->owner) {
html("<p>\n<h1>owner</h1>\n");
html("<h1>owner</h1>\n");
html_txt(cgit_repo->owner);
}
html("<p>\n<h1>navigate</h1>\n");
html("<h1>navigate</h1>\n");
reporevlink(NULL, "summary", NULL, "menu", cgit_query_head,
NULL, NULL);
cgit_log_link("log", NULL, "menu", cgit_query_head, NULL, NULL,
@ -484,19 +484,19 @@ void cgit_print_pageheader(char *title, int show_search)
for_each_ref(print_archive_ref, &header);
html("<p>\n<h1>branch</h1>\n");
html("<h1>branch</h1>\n");
html("<form method='get' action=''>\n");
add_hidden_formfields(0, 1, cgit_query_page);
html("<table class='grid'><tr><td id='branch-dropdown-cell'>");
html("<table summary='branch selector' class='grid'><tr><td id='branch-dropdown-cell'>");
html("<select name='h' onchange='this.form.submit();'>\n");
for_each_branch_ref(print_branch_option, cgit_query_head);
html("</select>\n");
html("</td><td>");
html("<noscript><input type='submit' id='switch-btn' value='..'></noscript>\n");
html("<noscript><input type='submit' id='switch-btn' value='..'/></noscript>\n");
html("</td></tr></table>");
html("</form>\n");
html("<p>\n<h1>search</h1>\n");
html("<h1>search</h1>\n");
html("<form method='get' action='");
if (cgit_virtual_root)
html_attr(cgit_fileurl(cgit_query_repo, "log",
@ -519,7 +519,7 @@ void cgit_print_pageheader(char *title, int show_search)
html("</div>\n");
html("</div>\n<table class='grid'><tr><td id='content'>\n");
html("</div>\n<table summary='page content' class='grid'><tr><td id='content'>\n");
}

2
ui-summary.c
View File

@ -190,7 +190,7 @@ void cgit_print_summary()
if (cgit_summary_log > 0)
cgit_print_log(cgit_query_head, 0, cgit_summary_log, NULL,
NULL, NULL, 0);
html("<table class='list nowrap'>");
html("<table summary='repository info' class='list nowrap'>");
if (cgit_summary_log > 0)
html("<tr class='nohover'><td colspan='4'>&nbsp;</td></tr>");
cgit_print_branches(cgit_summary_branches);

6
ui-tree.c
View File

@ -17,7 +17,7 @@ static void print_object(const unsigned char *sha1, char *path)
enum object_type type;
char *buf;
unsigned long size, lineno, start, idx;
const char *linefmt = "<tr><td class='no'><a name='%1$d'>%1$d</a></td><td class='txt'>";
const char *linefmt = "<tr><td class='no'><a id='n%1$d' name='n%1$d' href='#n%1$d'>%1$d</a></td><td class='txt'>";
type = sha1_object_info(sha1, &size);
if (type == OBJ_BAD) {
@ -37,7 +37,7 @@ static void print_object(const unsigned char *sha1, char *path)
html_attr(cgit_pageurl(cgit_query_repo, "blob", fmt("id=%s", sha1_to_hex(sha1))));
htmlf("'>%s</a>",sha1_to_hex(sha1));
html("<table class='blob'>\n");
html("<table summary='blob content' class='blob'>\n");
idx = 0;
start = 0;
lineno = 0;
@ -108,7 +108,7 @@ static int ls_item(const unsigned char *sha1, const char *base, int baselen,
static void ls_head()
{
html("<table class='list'>\n");
html("<table summary='tree listing' class='list'>\n");
html("<tr class='nohover'>");
html("<th class='left'>Mode</th>");
html("<th class='left'>Name</th>");