mirrors/cgit
0
0
Fork 0
mirror of https://git.zx2c4.com/cgit synced 2024-11-22 16:38:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Support unannotated tags in git-clone.

Browse Source 
Matthew McClintock reported that older unannotated tags were not
correctly being cloned and did not appear in info/refs. Further
investigation revealed some dubious prefix comparison code for
determining whether or not to write refs in info/refs. After comparing
it with git's own http-backend.c, it appears upstream does not use this
prefix logic.

OTOH, I don't know what the reasoning was when the prefix logic was
introduced. It appears to me to just be buggy, though it's possible
there are other reasons, and we'll have to revisit this commit.

But for now, Works For Me.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Matthew McClintock <msm@freescale.com>
Reported-by: Matthew McClintock <msm@freescale.com>
This commit is contained in:
Jason A. Donenfeld 2013-02-01 21:08:51 +01:00
parent 225c8aba31
commit 05da4c2822
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ui-clone.c
View File

@ -19,12 +19,10 @@ static int print_ref_info(const char *refname, const unsigned char *sha1,
if (!(obj = parse_object(sha1))) if (!(obj = parse_object(sha1)))
return 0; return 0;
if (!strcmp(refname, "HEAD") || !prefixcmp(refname, "refs/heads/")) htmlf("%s\t%s\n", sha1_to_hex(sha1), refname);
htmlf("%s\t%s\n", sha1_to_hex(sha1), refname); if (obj->type == OBJ_TAG) {
else if (!prefixcmp(refname, "refs/tags") && obj->type == OBJ_TAG) {
if (!(obj = deref_tag(obj, refname, 0))) if (!(obj = deref_tag(obj, refname, 0)))
return 0; return 0;
htmlf("%s\t%s\n", sha1_to_hex(sha1), refname);
htmlf("%s\t%s^{}\n", sha1_to_hex(obj->sha1), refname); htmlf("%s\t%s^{}\n", sha1_to_hex(obj->sha1), refname);
} }
return 0; return 0;