mirror of
https://gitlab.nic.cz/labs/bird.git
synced 2024-11-17 08:38:42 +00:00
e8bc64e308
The bgpmask literals can include expressions. This is OK but they have
to be interpreted as soon as the code is run, not in the time the code
is used as value.
This led to strange behavior like rewriting bgpmasks when they shan't
be rewritten:
function mask_generator(int as)
{
return [= * as * =];
}
function another()
bgpmask m1;
bgpmask m2;
{
m1 = mask_generator(10);
m2 = mask_generator(20);
if (m1 == m2) {
print("strange"); # this would happen
}
}
Moreover, sending this to CLI would cause stack overflow and knock down the
whole BIRD, as soon as there is at least one route to execute the given
filter on.
show route filter bgpmask mmm; bgppath ppp; { ppp = +empty+; mmm = [= (ppp ~ mmm) =]; print(mmm); accept; }
The magic match operator (~) inside the bgpmask literal would try to
resolve mmm, which points to the same bgpmask so it would resolve
itself, call the magic match operator and vice versa.
After this patch, the bgpmask literal will get resolved as soon as it's
assigned to mmm and it also will return a type error as bool is not
convertible to ASN in BIRD.
|
||
|---|---|---|
| .. | ||
| a-path.c | ||
| a-set.c | ||
| attrs.h | ||
| bfd.h | ||
| bird.h | ||
| cli.c | ||
| cli.h | ||
| cmds.c | ||
| cmds.h | ||
| config.Y | ||
| Doc | ||
| iface.c | ||
| iface.h | ||
| locks.c | ||
| locks.h | ||
| Makefile | ||
| mrtdump.h | ||
| neighbor.c | ||
| password.c | ||
| password.h | ||
| proto-hooks.c | ||
| proto.c | ||
| proto.sgml | ||
| protocol.h | ||
| route.h | ||
| rt-attr.c | ||
| rt-dev.c | ||
| rt-dev.h | ||
| rt-fib.c | ||
| rt-roa.c | ||
| rt-table.c | ||