mirror of
https://gitlab.nic.cz/labs/bird.git
synced 2024-11-18 00:58:42 +00:00
c1632ad0f3
This issue has a long history. In 2012, we changed data field for unnumbered PtP links from iface id (specified by RFC) to IP address based on reports of bugs in Quagga that required it, and we used out-of-band information to distinquish unnumberred PtPs with the same local IP address. Then with OSPF graceful restart implementation, we found that we can no longer use out-of-band information, and we need to use only LSAdb info for routing table calculation, but i forgot to finish handling of this case, so multiple unnumbered PtPs with the same local IP addresses were broken. Considering that even recent Mikrotik RouterOS has broken next hop calculation that depends on IP address in PtP link data field, we cannot just switch back to the iface id for unnumbered PtP links. The patch makes two changes: First, it goes back to use out-of-band (position) info for distinguishing local interfaces in SPF when graceful restart is not enabled, while still uses LSAdb-only approach for SPF calculation when graceful restart is enabled. Second, it adds OSPF interface option 'ptp address', which controls whether IP address or iface id is used in data field. It is enabled by default except for unnumbered PtP links with enabled graceful restart. Thanks to Kenth Eriksson for the bugreport and Joakim Tjernlund for suggestions. |
||
|---|---|---|
| .. | ||
| config.Y | ||
| dbdes.c | ||
| Doc | ||
| hello.c | ||
| iface.c | ||
| lsack.c | ||
| lsalib.c | ||
| lsalib.h | ||
| lsreq.c | ||
| lsupd.c | ||
| Makefile | ||
| neighbor.c | ||
| ospf.c | ||
| ospf.h | ||
| packet.c | ||
| rt.c | ||
| rt.h | ||
| topology.c | ||
| topology.h | ||