Maria Matejka
a9c1966f08
Merge remote-tracking branch 'origin/apkg-v3' into thread-next
2024-12-12 21:07:53 +01:00
Maria Matejka
6e940c259d
CLI: show threads all crash fixed
...
When socket dropped before finished, it failed to cleanup.
2024-12-12 15:00:26 +01:00
Maria Matejka
1f8eb20710
Merge commit '946386f2' into thread-next
2024-12-10 23:55:05 +01:00
Maria Matejka
cc0c8ce992
BMP: Fixing corner cases
...
Protocol state propagation collision, shutdown collision.
2024-12-10 23:41:48 +01:00
Maria Matejka
cde582977f
BMP: Never touching the BGP directly
...
Dropped hopefully last remnants of BMP directly accessing BGP structures.
2024-12-10 23:41:48 +01:00
Maria Matejka
dc692ae06a
Nest: proto/channel state table naming convention cleanup
2024-12-10 23:41:48 +01:00
Jakub Ružička
eaadf3af3a
Fix typos found by lintian
...
I: bird3: spelling-error-in-binary "an other" "another" [usr/sbin/bird]
I: bird3: spelling-error-in-binary Reseting Resetting [usr/sbin/bird]
I: bird3: spelling-error-in-binary authenication authentication [usr/sbin/bird]
I was unable to fix the following:
I: bird3: spelling-error-in-binary upto up to [usr/sbin/bird]
2024-12-06 16:09:31 +01:00
Maria Matejka
77a4b21365
BMP: Dropped remnants of unused channels
2024-12-05 15:10:15 +01:00
Maria Matejka
f1a04ce190
BMP: refactored lists and table locks to tlists
2024-12-05 14:59:54 +01:00
Maria Matejka
d5f01efbe6
BMP: protocol state ingestion refactoring
2024-12-05 12:12:34 +01:00
Maria Matejka
2128c648e0
BMP: Tamed a TX buffer warning
2024-12-04 10:16:42 +01:00
Ondrej Zajicek
63221eba2e
Merge commit 'a47704a53db4f088e52e43f8b24785e5777ce147' into thread-next
2024-12-03 19:40:21 +01:00
Ondrej Zajicek
723a0fe424
Merge commit '73e7d3f5cede2e72eb9e77d61424a8c443672c09' into thread-next
2024-12-03 19:00:05 +01:00
Ondrej Zajicek
abc43c097a
Merge commit '5205ff97448cc34cf7334e90172c28eb48f227f2' into thread-next
2024-12-03 18:48:20 +01:00
Ondrej Zajicek
7cbcb7b230
Merge commit 'e6a100b31a7637ee739338e4b933367707ec931f' into thread-next
2024-12-03 18:22:14 +01:00
Ondrej Zajicek
6aea356b2a
Merge commit '460321cfe979459e3b78ba87694f29865d321612' into thread-next
2024-12-03 15:45:25 +01:00
Maria Matejka
946386f2dd
MRT: instead of crashing, ignore non-BGP attributes
2024-12-02 04:27:30 +01:00
Ondrej Zajicek
a47704a53d
BMP: Refactor route monitor message serialization
...
Instead of several levels of functions, just have two functions
(one for routes, the other for end-of-rib), this allows to create
messages in a simple linear fashion.
Also reduce three duplicite functions to construct BGP header for
BMP messages to just one.
2024-12-02 03:38:17 +01:00
Ondrej Zajicek
73e7d3f5ce
BMP: Refactor computation of message length
...
Fill message length after the message is created instead of computing
it beforehand. Also rename some functions to fit common pattern.
2024-12-02 03:38:17 +01:00
Ondrej Zajicek
5205ff9744
BMP: Refactor per-peer header arguments
...
Put all arguments for per-peer header into one structure instead of
passing them around as a lump of arguments. Also simplify code for
peer flags.
2024-12-02 03:38:17 +01:00
Maria Matejka
e6a100b31a
BMP: simplified update queuing and better memory performance
...
This commit is quite a substantial rework of the underlying layers in
BMP TX:
- several unnecessary layers of indirection dropped, including most of
the original BMP's buffer machinery
- all messages are now written directly into one protocol's buffer
allocated for the whole time big enough to fit every possible message
- output blocks are allocated by pages and immediately returned when
used, improving the overall memory footprint
- no intermediary allocation is done from the heap altogether
- there is a documented and configurable limit on the TX queue size
2024-12-02 03:38:17 +01:00
Maria Matejka
c48a7ac0cc
BMP: drop an unused mempool
2024-11-29 16:06:07 +01:00
Maria Matejka
bda81c62bf
Merge commit '3ca6e03d' into thread-merge-2.16
2024-11-29 12:07:10 +01:00
Maria Matejka
cd63810e4e
Merge commit '997d2f57' into thread-merge-2.16
2024-11-29 11:43:49 +01:00
Maria Matejka
1b0ffdf80e
Merge commit '82d57fb7' into thread-merge-2.16
2024-11-29 11:26:18 +01:00
Maria Matejka
c1ad3e58c0
Merge commit '38195ac6' into thread-merge-2.16
2024-11-29 10:49:53 +01:00
Maria Matejka
145fcd3180
Merge commit 'c7e843c1' into thread-merge-2.16
2024-11-29 10:28:19 +01:00
Maria Matejka
baf963973d
Merge commit '80ca0ed2' into thread-merge-2.16
...
Fixed a nasty merge conflict with bgp_origin serving double duty
as both an attribute and enum name.
2024-11-29 10:20:08 +01:00
Maria Matejka
3ca6e03db7
RPKI: refactored pdu to host byte order conversion
...
We shouldn't convert bytes 2 and 3 of the PDU blindly, there are several
cases where these are used by bytes. Instead, the conversion is done
only where needed.
This fixes misinterpretation bug of ASPA PDU flags on little endian
architectures.
2024-11-28 14:19:47 +01:00
Maria Matejka
c0dfd4dc3b
Merge commit '8dc2a36a' into thread-merge-2.16
2024-11-28 12:23:14 +01:00
Maria Matejka
e6242ef948
Merge commit '8a40bccf' into thread-merge-2.16
2024-11-28 09:36:33 +01:00
Maria Matejka
ce2ecbdcb6
Merge commit 'e29f134a' into thread-merge-2.16
2024-11-28 09:04:31 +01:00
Maria Matejka
402d07bccd
Merge commit '280daed5' into thread-merge-2.16
2024-11-28 09:02:59 +01:00
Maria Matejka
d73d861f0c
Merge commit '08571b20' into thread-merge-2.16
2024-11-28 08:22:06 +01:00
Maria Matejka
01377599da
RPKI: Polishing of ASPA syntax and documentation
2024-11-26 18:11:39 +01:00
Ondrej Zajicek
fb919ac2a2
RPKI: Fix PDU length check
...
The END_OF_DATA PDU was extended in version 1, so it has different length
in different versions. We should do the PDU length check according to its
version.
2024-11-26 17:52:51 +01:00
Maria Matejka
e330fb1614
RPKI: added documentation and RTR version config options
2024-11-26 04:47:33 +01:00
Katerina Kubecova
fa65e06372
RPKI: protocol version 2, loading ASPA
...
Implemented draft-ietf-sidrops-8210bis-16, interoperable with StayRTR
development branches.
2024-11-26 04:14:36 +01:00
Maria Matejka
2956faf5a6
Protocol and BGP state information cleanup and fixes
...
There were some nasty problems with deferred protocol state updates and
race conditions on BGP startup, shutdown, and also with referencing the
cached states.
Now it looks fixed.
2024-11-24 22:51:08 +01:00
Katerina Kubecova
77dee46e98
BMP: updated to v3 API
2024-11-21 10:29:10 +01:00
Maria Matejka
d2ad795c1e
BGP: protocol specific state information cleanup
2024-11-21 09:21:29 +01:00
Maria Matejka
74800729c0
Proto: The active flag converted to actual fifth protocol state
...
What was PS_DOWN before, is now PS_DOWN and PS_FLUSH.
2024-11-18 22:21:12 +01:00
Katerina Kubecova
dc69284f61
MRT: buildable and running again for BIRD 3
...
Tests for MRT are scarce and not automated for now, so it may behave
weirdly in corner cases.
2024-11-14 11:41:37 +01:00
Maria Matejka
eb6918e4db
Neighbor cache: fixed neighbor referencing
2024-11-14 11:41:37 +01:00
Katerina Kubecova
c0319183a5
BGP: exporting protocol-specific state information
2024-11-14 11:41:37 +01:00
Maria Matejka
fa75007156
BGP: Start state is now using extended state
2024-11-14 11:41:37 +01:00
Piotr Wydrych
82d57fb7ad
CLI: Add timeformat command
...
Adds ability to override time format of show commands for current CLI session
so that it does not depend on configuration and may ease parsing when CLI is
called from tools.
Minor changes by committer.
2024-11-07 15:08:51 +01:00
Maria Matejka
38195ac628
ASPA: fixed the check algorithm to actually do what is in the RFC
...
The original algorithm assumed principles not consistent with the RFC
and could have lead to false invalids.
Also added filter tests showing also how the ASPA literals are used in
the static protocol.
2024-11-07 15:08:14 +01:00
Ondrej Zajicek
c7e843c1a7
BGP: Add RFC 9687 to list of supported RFCs
2024-11-07 15:07:22 +01:00
Maria Matejka
b4196b70c4
BGP: SendHoldTimer became an RFC, updating docs
2024-11-06 13:05:32 +01:00
