0
0
mirror of https://gitlab.nic.cz/labs/bird.git synced 2024-12-22 17:51:53 +00:00
Commit Graph

1670 Commits

Author SHA1 Message Date
Igor Putovny
74c48ab088 Add more assertions 2023-12-05 14:30:13 +01:00
Igor Putovny
49ee481280 Make pointer to aggregator bucket const 2023-12-05 14:25:08 +01:00
Igor Putovny
ff74440a52 Do not discard bucket from internal nodes 2023-11-22 13:09:48 +01:00
Igor Putovny
5ef7e9ab37 Do not assign bucket of any prefix to the root node 2023-11-22 13:01:59 +01:00
Igor Putovny
b574c62d57 Create event to run ORTC algorithm exactly once 2023-11-21 12:58:24 +01:00
Igor Putovny
54491f9606 Run ORTC algorithm 2023-11-21 12:41:14 +01:00
Igor Putovny
c78a25d9de Add assertions and general code improvements 2023-11-16 17:15:02 +01:00
Igor Putovny
ae8c718df3 Remove unused code 2023-11-16 16:59:14 +01:00
Igor Putovny
edb6ba6f84 Rename constant 2023-10-20 13:13:47 +02:00
Igor Putovny
4bcf7ac37f Fix how bucket for new leaf nodes is chosen 2023-10-20 13:11:49 +02:00
Igor Putovny
f7e3a3f0a0 Use net_addr_ip4 instead of ip4_addr for printing prefixes 2023-10-20 12:20:12 +02:00
Igor Putovny
990cd14e4a Remove unused code 2023-10-20 11:59:23 +02:00
Igor Putovny
18c32a286c Add comments 2023-10-18 12:12:27 +02:00
Igor Putovny
d9ef88698f Change order of parameters in a few functions 2023-10-18 12:06:27 +02:00
Igor Putovny
a7d2b780d0 Simplify delete_trie() function 2023-10-13 15:26:03 +02:00
Igor Putovny
aa611e48e0 Assign bucket of ancestor node to leaf node 2023-10-06 14:38:07 +02:00
Igor Putovny
67e6a3e351 Fix incorrect implementation of the third pass 2023-10-06 14:19:04 +02:00
Igor Putovny
b003ffd348 Assign route bucket only to the last inserted node 2023-10-06 13:52:27 +02:00
Igor Putovny
3c87d99fe4 Fix argument order in several functions 2023-10-06 13:40:49 +02:00
Igor Putovny
0abecd3002 Add a few comments, print prefixes after aggregation 2023-10-06 12:52:08 +02:00
Igor Putovny
c164515fb6 Extend remove_node() with deleting root node 2023-09-21 13:49:59 +02:00
Igor Putovny
aec8688fbc Fix aggregator_bucket_unionize()
The last two while loops were incorrectly placed inside the first while loop
2023-09-21 12:40:00 +02:00
Igor Putovny
b81e91bed6 Fix const warning, add few comments 2023-09-20 13:46:34 +02:00
Igor Putovny
4dffb687f1 Delete trie during aggregator shutdown 2023-09-20 13:05:49 +02:00
Igor Putovny
c2627f45fd Refactor and fix aggregator_bucket_unionize() 2023-09-20 12:19:01 +02:00
Igor Putovny
144e6c393c Fix aggregator_bucket_intersect(), add comments and fix naming 2023-09-19 12:06:52 +02:00
Igor Putovny
ead1ade4c2 Remove unused code 2023-09-18 14:48:22 +02:00
Igor Putovny
ce1e256874 Add new implementation of third_pass() and remove old implementation 2023-09-18 14:18:25 +02:00
Igor Putovny
812e646625 Move trie initialization to aggregator_start() 2023-09-15 11:04:37 +02:00
Igor Putovny
b48ac47aec Fix previous version, aggregator is now stable but untested 2023-09-14 09:33:14 +02:00
Igor Putovny
e94c9cbf36 Implement basics of prefix aggregation functionality 2023-09-11 12:38:19 +02:00
Maria Matejka
0a408c22f6 Aggregator: Fixed hashing of adata 2023-07-12 15:11:00 +02:00
Maria Matejka
2e8e901262 Aggregator moved to a separate protocol
Also updated data structures and reconfigure.

Known bug: the hash doesn't take adata into account. Needs fixing!
2023-07-10 13:46:09 +02:00
Maria Matejka
8ccc4d0679 Aggregator: polishing of filter API 2023-06-23 11:28:19 +02:00
Igor Putovny
e9d9dc7561 Basic route aggregation
User can specify list of route attributes in the configuration file
and run route aggregation on the export side of the pipe protocol.
Routes are sorted and for every group of equivalent routes
new route is created and exported to the routing table.
It is also possible to specify filter which will run for every
route before aggregation.
Furthermore, it will be possible to set attributes of new routes
according to attributes of the aggregated routes.

This is a work in progress.
2023-06-23 09:43:38 +02:00
Maria Matejka
c6494e45a6 Conf: config warnings show the file position 2023-06-17 00:03:30 +02:00
Maria Matejka
08d4205754 Conf: Symbol manipulation gets its context explicitly 2023-06-13 10:51:03 +02:00
Maria Matejka
df338396cd Conf: Symbol hashes for all scopes
This is a backport cherry-pick of commits
  165156beeb
  cce974e8ea

from the v3.0 branch as we need symbol hashes directly inside their
scopes for more general usage than before.

The redefinable keywords must be specified in any .Y file as follows:

  toksym: THE_KEYWORD ;
2023-06-09 13:49:31 +02:00
Ondrej Zajicek
69372dc9aa Babel: Minor changes to RTT formatting
Use existing %t printf code and move 'ms' in CLI output to table header.
2023-06-02 02:34:05 +02:00
Toke Høiland-Jørgensen
f08abcb8dd Babel: Add support for the RTT extension
This adds support to the Babel protocol for the RTT extension specified
in draft-ietf-babel-rtt-extension. While this extension is not yet at the
RFC stage, it is one of the more useful extensions to Babel[0], so it
seems worth having in Bird as well.

The extension adds timestamps to Hello and IHU TLVs and uses these to
compute an RTT to each neighbour. An extra per-neighbour cost is then
computed from the RTT based on a minimum and maximum interval and cost
value specified in the configuration. The primary use case for this is
improving routing in a geographically distributed tunnel-based overlay
network.

The implementation follows the babeld implementation when picking
constants and default configuration values. It also uses the same RTT
smoothing algorithm as babeld, and follows it in adding a new 'tunnel'
interface type which enables RTT by default.

[0] https://alioth-lists.debian.net/pipermail/babel-users/2022-April/003932.html
2023-06-02 00:31:53 +02:00
Ondrej Zajicek
f8ba82804f BGP: Fix role check when no capability option is present
When an OPEN message without capability options was parsed, the remote
role field was not initialized with the proper (non-zero) default value,
so it was interpreted as if 'provider' was announced.

Thanks to Mikhail Grishin for the bugreport.
2023-05-19 01:02:57 +02:00
Ondrej Zajicek
a8a64ca0fe Conf: Improve handling of keywords
For whatever reason, parser allocated a symbol for every parsed keyword
in each scope. That wasted time and memory. The effect is worsened with
recent changes allowing local scopes, so keywords often promote soft
scopes (with no symbols) to real scopes.

Do not allocate a symbol for a keyword. Take care of keywords that could
be promoted to symbols (kw_sym) and do it explicitly.
2023-04-27 18:41:01 +02:00
Ondrej Zajicek
976dec048a BMP: Silence some log messages
Hooks called from BGP to BMP should not log warning when BMP is not
connected, that is not an error (and we do not want to flood logs with
a ton of messages).

Blocked sk_send() should not log warning, that is expected situation.
Error during sk_send() is handled in error hook anyway.
2023-04-20 17:14:45 +02:00
Ondrej Zajicek
2c7d2141ac BMP: Fix connection management
Replace broken TCP connection management with a simple state machine.
Handle failed attempts properly with a timeout, detect and handle TCP
connection close and try to reconnect after that. Remove useless
'station_connected' flag.

Keep open messages saved even after the BMP session establishment,
so they can be used after BMP session flaps.

Use proper log messages for session events.
2023-04-20 16:28:07 +02:00
Ondrej Zajicek
010df43519 BMP: Fix reconfiguration
It is not supported, but at least it must update internal config
pointer to not keep old one.
2023-04-18 18:57:54 +02:00
Ondrej Zajicek
02164814b4 BMP: Allow build without BMP and disable BMP build by default
It has still several important issues to be enabled by default.
2023-04-18 17:21:13 +02:00
Ondrej Zajicek
fbeef4b74d BMP: Move initialization to bmp_start()
That fixes BMP socket allocation from an invalid pool.
2023-04-18 15:13:24 +02:00
Ondrej Zajicek
04e3a76c94 BMP: Fix missing template
It is mandatory for protocol.
2023-04-18 15:09:21 +02:00
Ondrej Zajicek (work)
3925e65938 BMP: Add some missing bmp_buffer_free() calls
They were inadvertently removed during recent code refactoring.

Thanks to Dawid Macek for the bugreport and patch.
2023-04-16 20:06:02 +02:00
Ondrej Zajicek (work)
4d56b70dc5 BMP: Remove duplicate functions for update encoding
Use existing BGP functions also for BMP update encoding.
2023-04-16 20:06:00 +02:00