0
0
mirror of https://gitlab.nic.cz/labs/bird.git synced 2024-12-22 09:41:54 +00:00
Commit Graph

4175 Commits

Author SHA1 Message Date
Igor Putovny
2d2354f54e Assign route bucket only to the last inserted node 2024-05-30 12:30:00 +02:00
Igor Putovny
1712d83c01 Fix argument order in several functions 2024-05-30 12:30:00 +02:00
Igor Putovny
ec1eb83bf0 Add a few comments, print prefixes after aggregation 2024-05-30 12:30:00 +02:00
Igor Putovny
7657d05592 Extend remove_node() with deleting root node 2024-05-30 12:30:00 +02:00
Igor Putovny
26ac6dca5c Fix aggregator_bucket_unionize()
The last two while loops were incorrectly placed inside the first while loop
2024-05-30 12:30:00 +02:00
Igor Putovny
9954b24f57 Fix const warning, add few comments 2024-05-30 12:30:00 +02:00
Igor Putovny
f7161a875f Delete trie during aggregator shutdown 2024-05-30 12:30:00 +02:00
Igor Putovny
6d5e75e46d Refactor and fix aggregator_bucket_unionize() 2024-05-30 12:30:00 +02:00
Igor Putovny
45c7a5463e Fix aggregator_bucket_intersect(), add comments and fix naming 2024-05-30 12:30:00 +02:00
Igor Putovny
d046a0a42f Remove unused code 2024-05-30 12:30:00 +02:00
Igor Putovny
5a933c6fe5 Add new implementation of third_pass() and remove old implementation 2024-05-30 12:30:00 +02:00
Igor Putovny
ca4a1dc9d3 Move trie initialization to aggregator_start() 2024-05-30 12:30:00 +02:00
Igor Putovny
7d93e8b7d3 Fix previous version, aggregator is now stable but untested 2024-05-30 12:30:00 +02:00
Igor Putovny
2d822231d4 Implement basics of prefix aggregation functionality 2024-05-30 12:30:00 +02:00
Maria Matejka
ccc5166280 Aggregator: Fixed hashing of adata 2024-05-30 12:30:00 +02:00
Maria Matejka
a582ee9c6d Aggregator moved to a separate protocol
Also updated data structures and reconfigure.

Known bug: the hash doesn't take adata into account. Needs fixing!
2024-05-30 12:30:00 +02:00
Maria Matejka
732b3981b5 Aggregator: polishing of filter API 2024-05-30 12:30:00 +02:00
Igor Putovny
c48de3cf85 Basic route aggregation
User can specify list of route attributes in the configuration file
and run route aggregation on the export side of the pipe protocol.
Routes are sorted and for every group of equivalent routes
new route is created and exported to the routing table.
It is also possible to specify filter which will run for every
route before aggregation.
Furthermore, it will be possible to set attributes of new routes
according to attributes of the aggregated routes.

This is a work in progress.
2024-05-30 12:30:00 +02:00
Maria Matejka
260de00383 Simple testing of reconfiguration to a slightly different one 2024-05-30 12:30:00 +02:00
Maria Matejka
f567e99f33 Filter: Print instructions take only one value (simplification) 2024-05-30 12:30:00 +02:00
Maria Matejka
3054e26980 Filter: Shortened method declarations 2024-05-30 12:30:00 +02:00
Maria Matejka
4a41bed418 Filter: The for loop uses the method system for type dispatch 2024-05-30 12:30:00 +02:00
Maria Matejka
8941589b97 Removing unused terminals from filter config 2024-05-30 12:30:00 +02:00
Maria Matejka
8ac15bf7a4 Filter: Methods rework
Methods can now be called as x.m(y), as long as x can have its type
inferred in config time. If used as a command, it modifies the object,
if used as a value, it keeps the original object intact.

Also functions add(x,y), delete(x,y), filter(x,y) and prepend(x,y) now
spit a warning and are considered deprecated.

It's also possible to call a method on a constant, see filter/test.conf
for examples like bgp_path = +empty+.prepend(1).

Inside instruction definitions (filter/f-inst.c), a METHOD_CONSTRUCTOR()
call is added, which registers the instruction as a method for the type
of its first argument. Each type has its own method symbol table and
filter parser switches between them based on the inferred type of the
object calling the method.

Also FI_CLIST_(ADD|DELETE|FILTER) instructions have been split to allow
for this method dispatch. With type inference, it's now possible.
2024-05-30 12:30:00 +02:00
Maria Matejka
44bac39361 Uninitialized filter variables of path/[el]?clist types are now explicitly empty 2024-05-30 12:30:00 +02:00
Maria Matejka
9bdc769851 Conf: config warnings show the file position 2024-05-30 12:30:00 +02:00
Maria Matejka
79468e7c19 Filter: functions can and should have typed return values 2024-05-30 12:30:00 +02:00
Maria Matejka
ee4fbcf5dc GitLab: Disabling build for CentOS 7 and Ubuntu 14.04 as our build machines don't like C11 2024-05-30 12:30:00 +02:00
Maria Matejka
c0c695c761 Filter/Conf: Method names have their own keyword hash
To allow for future dynamic method definition, parsing method names is
done via a dedicated keyword hash/scope.
2024-05-30 12:30:00 +02:00
Maria Matejka
ab785d1ec4 Conf: Allowing conf scope to be explicitly read only 2024-05-30 12:30:00 +02:00
Maria Matejka
0323471062 Conf: Symbol manipulation gets its context explicitly 2024-05-30 12:30:00 +02:00
Maria Matejka
f88583b903 Filter: any lvalue can get its methods called 2024-05-30 12:30:00 +02:00
Maria Matejka
7b65343937 Filter: split out dot-notation methods to separate targets
This is just a preparationary refactoring to allow type-based method
tables.
2024-05-30 12:30:00 +02:00
Maria Matejka
7e6a8392ce Conf: Keywords have their default symbols
This avoids unnecessary collapsed soft scopes caused by keyword symbol multiallocation.
2024-05-30 12:30:00 +02:00
Maria Matejka
51e8996fff Conf: Symbol hashes for all scopes
This is a backport cherry-pick of commits
  165156beeb
  cce974e8ea

from the v3.0 branch as we need symbol hashes directly inside their
scopes for more general usage than before.

The redefinable keywords must be specified in any .Y file as follows:

  toksym: THE_KEYWORD ;
2024-05-30 12:30:00 +02:00
Maria Matejka
4938c122dc Dropping empty-type const f_vals, they were copied anyway 2024-05-30 12:30:00 +02:00
Maria Matejka
4167635b79 Conf: Adding dummy thread-number setting for easier sharing of configuration between v2 and v3 2024-05-30 12:30:00 +02:00
Ondrej Zajicek
7b3b8a8949 Babel: Minor changes to RTT formatting
Use existing %t printf code and move 'ms' in CLI output to table header.
2024-05-30 12:30:00 +02:00
Toke Høiland-Jørgensen
ed3b730ac3 Babel: Add support for the RTT extension
This adds support to the Babel protocol for the RTT extension specified
in draft-ietf-babel-rtt-extension. While this extension is not yet at the
RFC stage, it is one of the more useful extensions to Babel[0], so it
seems worth having in Bird as well.

The extension adds timestamps to Hello and IHU TLVs and uses these to
compute an RTT to each neighbour. An extra per-neighbour cost is then
computed from the RTT based on a minimum and maximum interval and cost
value specified in the configuration. The primary use case for this is
improving routing in a geographically distributed tunnel-based overlay
network.

The implementation follows the babeld implementation when picking
constants and default configuration values. It also uses the same RTT
smoothing algorithm as babeld, and follows it in adding a new 'tunnel'
interface type which enables RTT by default.

[0] https://alioth-lists.debian.net/pipermail/babel-users/2022-April/003932.html
2024-05-30 12:30:00 +02:00
Toke Høiland-Jørgensen
7176f62788 IO: Add current_time_now() function for immediate timestamp
Add a current_time_now() function which gets an immediate monotonic
timestamp instead of using the cached value from the event loop. This is
useful for callers that need precise times, such as the Babel RTT
measurement code.

Minor changes by committer.
2024-05-30 12:30:00 +02:00
Ondrej Zajicek
d7163f6427 BGP: Fix role check when no capability option is present
When an OPEN message without capability options was parsed, the remote
role field was not initialized with the proper (non-zero) default value,
so it was interpreted as if 'provider' was announced.

Thanks to Mikhail Grishin for the bugreport.
2024-05-30 12:30:00 +02:00
Ondrej Zajicek
104fc34f94 Lib: Improve IP/net hashing
Backport some changes from branch oz-parametric-hashes. Replace naive
hash function for IPv6 addresses, fix hashing of VPNx (where upper half
of RD was ignored), fix hashing of MPLS labels (where identity was used).
2024-05-30 12:30:00 +02:00
Ondrej Zajicek
6c2979f4d0 Nest: Add tests and benchmark for FIB
Basic fib_get() / fib_find() test for random prefixes, FIB_WALK() test,
and benchmark for fib_find(). Also generalize and reuse some code from
trie tests.
2024-05-30 12:30:00 +02:00
Ondrej Zajicek
d44409f0c0 Conf: Improve handling of keywords
For whatever reason, parser allocated a symbol for every parsed keyword
in each scope. That wasted time and memory. The effect is worsened with
recent changes allowing local scopes, so keywords often promote soft
scopes (with no symbols) to real scopes.

Do not allocate a symbol for a keyword. Take care of keywords that could
be promoted to symbols (kw_sym) and do it explicitly.
2024-05-30 12:30:00 +02:00
Ondrej Zajicek
3aef1bc7fc Conf: Fix symbol lookup
The symbol table used just symbol name as a key, and used a trick with
active flag to find symbols in active scopes with one hash table lookup.

The disadvantage is that it can degenerate to O(n) for negative queries
in situations where are many symbols with the same name in different
scopes.

Thanks to Yanko Kaneti for the bugreport.
2024-05-30 12:30:00 +02:00
Ondrej Zajicek
220c0e548a NEWS and version update 2024-05-30 12:30:00 +02:00
Ondrej Zajicek
7e901192ed Filter: Disable some trie formatting tests
Trie formatting works slightly different with 4-way tries than with
16-way ones, so these tests generated false error. Block them for now.
2024-05-30 12:30:00 +02:00
Ondrej Zajicek
14135e6aba BMP: Add some basic documentation 2024-05-30 12:30:00 +02:00
Ondrej Zajicek
57da33172c BMP: Silence some log messages
Hooks called from BGP to BMP should not log warning when BMP is not
connected, that is not an error (and we do not want to flood logs with
a ton of messages).

Blocked sk_send() should not log warning, that is expected situation.
Error during sk_send() is handled in error hook anyway.
2024-05-30 12:30:00 +02:00
Ondrej Zajicek
8f78c232f6 BMP: Fix connection management
Replace broken TCP connection management with a simple state machine.
Handle failed attempts properly with a timeout, detect and handle TCP
connection close and try to reconnect after that. Remove useless
'station_connected' flag.

Keep open messages saved even after the BMP session establishment,
so they can be used after BMP session flaps.

Use proper log messages for session events.
2024-05-30 12:30:00 +02:00