mirrors/bird
mirrors/bird
0
0
Fork 0
mirror of https://gitlab.nic.cz/labs/bird.git synced 2024-12-31 06:01:52 +00:00
Code Releases Activity

VRF: Fix issues with reconfiguration

Browse Source 
Protocols receive if_notify() announcements that are filtered according
to their VRF setting, but during reconfiguration, they access iface_list
directly and forgot to check VRF setting here, which leads to all
interfaces be addedd.

Fix this issue for Babel, OSPF, RAdv and RIP protocols.

Thanks to Marcel Menzel for the bugreport.
This commit is contained in:
Ondrej Zajicek 2023-01-22 18:12:04 +01:00
parent 3186ffe797
commit a82683694d
4 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
proto/babel/babel.c
View File

@ -1946,6 +1946,9 @@ babel_reconfigure_ifaces(struct babel_proto *p, struct babel_config *cf)
WALK_LIST(iface, iface_list)
{
if (p->p.vrf_set && p->p.vrf != iface->master)
continue;
if (!(iface->flags & IF_UP))
continue;

6
proto/ospf/iface.c
View File

@ -1227,6 +1227,9 @@ ospf_reconfigure_ifaces2(struct ospf_proto *p)
WALK_LIST(iface, iface_list)
{
if (p->p.vrf_set && p->p.vrf != iface->master)
continue;
if (! (iface->flags & IF_UP))
continue;
@ -1273,6 +1276,9 @@ ospf_reconfigure_ifaces3(struct ospf_proto *p)
WALK_LIST(iface, iface_list)
{
if (p->p.vrf_set && p->p.vrf != iface->master)
continue;
if (! (iface->flags & IF_UP))
continue;

3
proto/radv/radv.c
View File

@ -663,6 +663,9 @@ radv_reconfigure(struct proto *P, struct proto_config *CF)
struct iface *iface;
WALK_LIST(iface, iface_list)
{
if (p->p.vrf_set && p->p.vrf != iface->master)
continue;
if (!(iface->flags & IF_UP))
continue;

3
proto/rip/rip.c
View File

@ -797,6 +797,9 @@ rip_reconfigure_ifaces(struct rip_proto *p, struct rip_config *cf)
WALK_LIST(iface, iface_list)
{
if (p->p.vrf_set && p->p.vrf != iface->master)
continue;
if (!(iface->flags & IF_UP))
continue;