mirrors/bird
mirrors/bird
0
0
Fork 0
mirror of https://gitlab.nic.cz/labs/bird.git synced 2025-01-05 08:31:53 +00:00
Code Releases Activity

BGP: When debug { routes } is set, updates considered as loop are logged

Browse Source
This commit is contained in:
Maria Matejka 2023-09-14 14:44:35 +02:00
parent 0faf3bb630
commit 8638c6f0b3
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
proto/bgp/attrs.c
View File

@ -135,6 +135,10 @@ bgp_unset_attr(ea_list **to, uint code)
#define REPORT(msg, args...) \ #define REPORT(msg, args...) \
({ log(L_REMOTE "%s: " msg, s->proto->p.name, ## args); }) ({ log(L_REMOTE "%s: " msg, s->proto->p.name, ## args); })
#define RTRACE(msg, args...) \
({ if (s->proto->p.debug & D_ROUTES) \
log(L_TRACE "%s: " msg, s->proto->p.name, ## args); })
#define DISCARD(msg, args...) \ #define DISCARD(msg, args...) \
({ REPORT(msg, ## args); return; }) ({ REPORT(msg, ## args); return; })
@ -1473,21 +1477,23 @@ bgp_decode_attrs(struct bgp_parse_state *s, byte *data, uint len)
if (!p->as4_session) if (!p->as4_session)
bgp_process_as4_attrs(&attrs, s->pool); bgp_process_as4_attrs(&attrs, s->pool);
#define IS_LOOP(msg, args...) { RTRACE("update is loop (" msg "), treating as withdraw", ##args); goto loop; }
/* Reject routes with our ASN in AS_PATH attribute */ /* Reject routes with our ASN in AS_PATH attribute */
if (bgp_as_path_loopy(p, attrs, p->local_as)) if (bgp_as_path_loopy(p, attrs, p->local_as))
goto loop; IS_LOOP("Our ASN %d in AS_PATH", p->local_as);
/* Reject routes with our Confederation ID in AS_PATH attribute; RFC 5065 4.0 */ /* Reject routes with our Confederation ID in AS_PATH attribute; RFC 5065 4.0 */
if ((p->public_as != p->local_as) && bgp_as_path_loopy(p, attrs, p->public_as)) if ((p->public_as != p->local_as) && bgp_as_path_loopy(p, attrs, p->public_as))
goto loop; IS_LOOP("Our Confederation ID %d in AS_PATH", p->public_as);
/* Reject routes with our Router ID in ORIGINATOR_ID attribute; RFC 4456 8 */ /* Reject routes with our Router ID in ORIGINATOR_ID attribute; RFC 4456 8 */
if (p->is_internal && bgp_originator_id_loopy(p, attrs)) if (p->is_internal && bgp_originator_id_loopy(p, attrs))
goto loop; IS_LOOP("Our Router ID is Originator ID");
/* Reject routes with our Cluster ID in CLUSTER_LIST attribute; RFC 4456 8 */ /* Reject routes with our Cluster ID in CLUSTER_LIST attribute; RFC 4456 8 */
if (p->rr_client && bgp_cluster_list_loopy(p, attrs)) if (p->rr_client && bgp_cluster_list_loopy(p, attrs))
goto loop; IS_LOOP("Our Cluster ID is in Cluster List");
/* If there is no local preference, define one */ /* If there is no local preference, define one */
if (!BIT32_TEST(s->attrs_seen, BA_LOCAL_PREF)) if (!BIT32_TEST(s->attrs_seen, BA_LOCAL_PREF))