mirrors/bird
mirrors/bird
0
0
Fork 0
mirror of https://gitlab.nic.cz/labs/bird.git synced 2024-11-14 15:18:44 +00:00
Code Releases Activity

Netindex: Dropping tmp handle mechanism in favor of deferred lfuc_unlock

Browse Source
This commit is contained in:
Maria Matejka 2024-04-01 20:04:14 +02:00
parent 46164395b2
commit 77659b1994
2 changed files with 22 additions and 61 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

69
lib/netindex.c
View File

@ -22,48 +22,15 @@ HASH_DEFINE_REHASH_FN(NETINDEX, struct netindex);
static void netindex_hash_cleanup(void *netindex_hash); static void netindex_hash_cleanup(void *netindex_hash);
/*
* Handle for persistent or semipersistent usage
*/
struct netindex_handle {
resource r;
struct netindex *index;
netindex_hash *h;
};
static void
net_unlock_index_persistent(resource *r)
{
struct netindex_handle *nh = SKIP_BACK(struct netindex_handle, r, r);
net_unlock_index(nh->h, nh->index);
}
static void
netindex_handle_dump(resource *r, unsigned indent UNUSED)
{
struct netindex_handle *nh = SKIP_BACK(struct netindex_handle, r, r);
debug("index=%u, net=%N", nh->index->index, nh->index->addr);
}
static struct resclass netindex_handle_class = {
.name = "Netindex handle",
.size = sizeof(struct netindex_handle),
.free = net_unlock_index_persistent,
.dump = netindex_handle_dump,
};
static struct netindex * static struct netindex *
net_lock_index_persistent(struct netindex_hash_private *hp, struct netindex *ni, pool *p) net_lock_revive_unlock(struct netindex_hash_private *hp, struct netindex *i)
{ {
if (!ni) if (!i)
return NULL; return NULL;
struct netindex_handle *nh = ralloc(p, &netindex_handle_class); lfuc_lock_revive(&i->uc);
// log(L_TRACE "Revive index %p", ni); lfuc_unlock(&i->uc, hp->cleanup_list, &hp->cleanup_event);
lfuc_lock_revive(&ni->uc); return i;
nh->index = ni;
nh->h = SKIP_BACK(netindex_hash, priv, hp);
return ni;
} }
/* /*
@ -151,14 +118,13 @@ net_find_index_fragile(struct netindex_hash_private *hp, const net_addr *n)
} }
static struct netindex * static struct netindex *
net_find_index_locked(struct netindex_hash_private *hp, const net_addr *n, pool *p) net_find_index_locked(struct netindex_hash_private *hp, const net_addr *n)
{ {
struct netindex *ni = net_find_index_fragile(hp, n); return net_lock_revive_unlock(hp, net_find_index_fragile(hp, n));
return ni ? net_lock_index_persistent(hp, ni, p) : NULL;
} }
static struct netindex * static struct netindex *
net_new_index_locked(struct netindex_hash_private *hp, const net_addr *n, pool *p) net_new_index_locked(struct netindex_hash_private *hp, const net_addr *n)
{ {
if (!hp->net[n->type].block) if (!hp->net[n->type].block)
netindex_hash_init(hp, n->type); netindex_hash_init(hp, n->type);
@ -178,7 +144,7 @@ net_new_index_locked(struct netindex_hash_private *hp, const net_addr *n, pool *
HASH_INSERT2(hp->net[n->type].hash, NETINDEX, hp->pool, ni); HASH_INSERT2(hp->net[n->type].hash, NETINDEX, hp->pool, ni);
return net_lock_index_persistent(hp, ni, p); return net_lock_revive_unlock(hp, ni);
} }
@ -199,24 +165,27 @@ void net_unlock_index(netindex_hash *h, struct netindex *i)
} }
struct netindex * struct netindex *
net_find_index_persistent(netindex_hash *h, const net_addr *n, pool *p) net_find_index(netindex_hash *h, const net_addr *n)
{ {
NH_LOCK(h, hp); NH_LOCK(h, hp);
return net_find_index_locked(hp, n, p); return net_find_index_locked(hp, n);
} }
struct netindex * struct netindex *
net_get_index_persistent(netindex_hash *h, const net_addr *n, pool *p) net_get_index(netindex_hash *h, const net_addr *n)
{ {
NH_LOCK(h, hp); NH_LOCK(h, hp);
return return
net_find_index_locked(hp, n, p) ?: net_find_index_locked(hp, n) ?:
net_new_index_locked(hp, n, p); net_new_index_locked(hp, n);
} }
struct netindex * struct netindex *
net_resolve_index_persistent(netindex_hash *h, u8 net_type, u32 i, pool *p) net_resolve_index(netindex_hash *h, u8 net_type, u32 i)
{ {
NH_LOCK(h, hp); NH_LOCK(h, hp);
return net_lock_index_persistent(hp, hp->net[net_type].block_size > i ? hp->net[net_type].block[i] : NULL, p); if (i >= hp->net[net_type].block_size)
return NULL;
else
return net_lock_revive_unlock(hp, hp->net[net_type].block[i]);
} }

14
lib/netindex.h
View File

@ -30,18 +30,10 @@ typedef union netindex_hash netindex_hash;
/* Initialization */ /* Initialization */
netindex_hash *netindex_hash_new(pool *); netindex_hash *netindex_hash_new(pool *);
/* Find/get/resolve index and allocate its usecount to the given pool */
struct netindex *net_find_index_persistent(netindex_hash *, const net_addr *, pool *);
struct netindex *net_get_index_persistent(netindex_hash *, const net_addr *, pool *);
struct netindex *net_resolve_index_persistent(netindex_hash *, u8, u32, pool *);
/* Find/get/resolve index; pointer valid until end of task */ /* Find/get/resolve index; pointer valid until end of task */
static inline struct netindex *net_find_index(netindex_hash *h, const net_addr *n) struct netindex *net_find_index(netindex_hash *, const net_addr *);
{ return net_find_index_persistent(h, n, tmp_res.pool); } struct netindex *net_get_index(netindex_hash *, const net_addr *);
static inline struct netindex *net_get_index(netindex_hash *h, const net_addr *n) struct netindex *net_resolve_index(netindex_hash *, u8, u32);
{ return net_get_index_persistent(h, n, tmp_res.pool); }
static inline struct netindex *net_resolve_index(netindex_hash *h, u8 net_type, u32 index)
{ return net_resolve_index_persistent(h, net_type, index, tmp_res.pool); }
/* Update use-count without allocating a handle. Take same care /* Update use-count without allocating a handle. Take same care
* to ensure that your locks and unlocks are always balanced. */ * to ensure that your locks and unlocks are always balanced. */