mirrors/bird
mirrors/bird
0
0
Fork 0
mirror of https://gitlab.nic.cz/labs/bird.git synced 2024-12-23 02:01:55 +00:00
Code Releases Activity

More thorough logging of route update corner cases

Browse Source
This commit is contained in:
Maria Matejka 2022-10-11 11:08:15 +02:00
parent 26552a7ec8
commit 6d5929be24
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
nest/rt-table.c
View File

@ -1792,6 +1792,9 @@ rte_recalculate(struct rtable_private *table, struct rt_import_hook *c, net *net
else else
rt_rte_trace_in(D_ROUTES, req, old, "removed [sole]"); rt_rte_trace_in(D_ROUTES, req, old, "removed [sole]");
} }
else
if (req->trace_routes & D_ROUTES)
log(L_TRACE "%s > ignored %N %s->%s", req->name, net->n.addr, old ? "filtered" : "none", new ? "filtered" : "none");
/* Propagate the route change */ /* Propagate the route change */
rte_announce(table, net, new_stored, old_stored, rte_announce(table, net, new_stored, old_stored,
@ -1835,7 +1838,10 @@ void
rte_update(struct channel *c, const net_addr *n, rte *new, struct rte_src *src) rte_update(struct channel *c, const net_addr *n, rte *new, struct rte_src *src)
{ {
if (!c->in_req.hook) if (!c->in_req.hook)
{
log(L_WARN "%s.%s: Called rte_update without import hook", c->proto->name, c->name);
return; return;
}
ASSERT(c->channel_state == CS_UP); ASSERT(c->channel_state == CS_UP);
@ -1906,7 +1912,10 @@ rte_import(struct rt_import_request *req, const net_addr *n, rte *new, struct rt
{ {
struct rt_import_hook *hook = req->hook; struct rt_import_hook *hook = req->hook;
if (!hook) if (!hook)
{
log(L_WARN "%s: Called rte_import without import hook", req->name);
return; return;
}
RT_LOCKED(hook->table, tab) RT_LOCKED(hook->table, tab)
{ {
@ -1924,6 +1933,8 @@ rte_import(struct rt_import_request *req, const net_addr *n, rte *new, struct rt
else if (!(nn = net_find(tab, n))) else if (!(nn = net_find(tab, n)))
{ {
req->hook->stats.withdraws_ignored++; req->hook->stats.withdraws_ignored++;
if (req->trace_routes & D_ROUTES)
log(L_TRACE "%s > ignored %N withdraw", req->name, n);
RT_RETURN(tab); RT_RETURN(tab);
} }