From 661ec5db7fa047d883997d0b2cbdd71659f80777 Mon Sep 17 00:00:00 2001 From: Ondrej Zajicek Date: Fri, 21 Nov 2008 13:05:12 +0100 Subject: [PATCH] I am not sure whether this is proper fix for a problem that birdc shows only parts of larger outputs (for example 'show route all'). It seems that birdc reads (from bird) and writes (to stdout) everything but during execution of some readline code some already written output disappeared (although it is fflush()ed and tcdrain()ed). As birdc reads from stdin when select said there are some data, O_NONBLOCK for stdin is unnecessary and when it is removed, i didn't notified this problem. --- client/client.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/client/client.c b/client/client.c index 905526a4..ce9bdb64 100644 --- a/client/client.c +++ b/client/client.c @@ -201,8 +201,9 @@ input_init(void) rl_add_defun("bird-help", input_help, '?'); rl_callback_handler_install("bird> ", got_line); input_initialized = 1; - if (fcntl(0, F_SETFL, O_NONBLOCK) < 0) - die("fcntl: %m"); +// readline library does strange things when stdin is nonblocking. +// if (fcntl(0, F_SETFL, O_NONBLOCK) < 0) +// die("fcntl: %m"); } static void