mirrors/bird
mirrors/bird
0
0
Fork 0
mirror of https://gitlab.nic.cz/labs/bird.git synced 2024-12-22 09:41:54 +00:00
Code Releases Activity

Bugfix - RIP now updates routes with worse metric.

Browse Source
This commit is contained in:
Ondrej Filip 2004-07-13 20:53:56 +00:00
parent bc956fcab6
commit 16c2d48d8f
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
proto/rip/rip.c
View File

@ -2,6 +2,7 @@
* Rest in pieces - RIP protocol * Rest in pieces - RIP protocol
* *
* Copyright (c) 1998, 1999 Pavel Machek <pavel@ucw.cz> * Copyright (c) 1998, 1999 Pavel Machek <pavel@ucw.cz>
* 2004 Ondrej Filip <feela@network.cz>
* *
* Can be freely distributed and used under the terms of the GNU GPL. * Can be freely distributed and used under the terms of the GNU GPL.
* *
@ -267,7 +268,6 @@ rip_rte_update_if_better(rtable *tab, net *net, struct proto *p, rte *new)
if (!old || p->rte_better(new, old) || if (!old || p->rte_better(new, old) ||
(ipa_equal(old->attrs->from, new->attrs->from) && (ipa_equal(old->attrs->from, new->attrs->from) &&
(old->u.rip.metric != new->u.rip.metric)) ) (old->u.rip.metric != new->u.rip.metric)) )
rte_update(tab, net, p, new); rte_update(tab, net, p, new);
} }
@ -361,8 +361,8 @@ process_block( struct proto *p, struct rip_block *block, ip_addr whotoldme )
ip_addr network = block->network; ip_addr network = block->network;
CHK_MAGIC; CHK_MAGIC;
TRACE(D_ROUTES, "block: %I tells me: %I/??? available, metric %d... ", whotoldme, network, metric ); TRACE(D_ROUTES, "block: %I tells me: %I/%d available, metric %d... ",
/* FIXME: Why `???'? If prefix is unknown, just don't print it. [mj] */ whotoldme, network, ipa_mklen(block->netmask), metric );
if ((!metric) || (metric > P_CF->infinity)) { if ((!metric) || (metric > P_CF->infinity)) {
#ifdef IPV6 /* Someone is sedning us nexthop and we are ignoring it */ #ifdef IPV6 /* Someone is sedning us nexthop and we are ignoring it */
if (metric == 0xff) if (metric == 0xff)
@ -881,6 +881,14 @@ rip_rt_notify(struct proto *p, struct network *net, struct rte *new, struct rte
} }
} }
static int
rip_rte_same(struct rte *new, struct rte *old)
{
/* new->attrs == old->attrs always */
return new->u.rip.metric == old->u.rip.metric;
}
static int static int
rip_rte_better(struct rte *new, struct rte *old) rip_rte_better(struct rte *new, struct rte *old)
{ {
@ -938,6 +946,7 @@ rip_init_instance(struct proto *p)
p->make_tmp_attrs = rip_make_tmp_attrs; p->make_tmp_attrs = rip_make_tmp_attrs;
p->store_tmp_attrs = rip_store_tmp_attrs; p->store_tmp_attrs = rip_store_tmp_attrs;
p->rte_better = rip_rte_better; p->rte_better = rip_rte_better;
p->rte_same = rip_rte_same;
p->rte_insert = rip_rte_insert; p->rte_insert = rip_rte_insert;
p->rte_remove = rip_rte_remove; p->rte_remove = rip_rte_remove;
} }