From 0443fbbe17deb127b0f446f7b8eeebcff5090763 Mon Sep 17 00:00:00 2001 From: Ondrej Zajicek Date: Sun, 19 Feb 2023 03:59:10 +0100 Subject: [PATCH] Conf: Fix too early free of old configuration The change 371eb49043d225d2bab8149187b813a14b4b86d2 introduced early free of old_config. Unfortunately, it did not properly check whether it is not still in use (blocked by obstacle during reconfiguration). Fix that. It also means that we still could have a short peak when three configs are in use (when a new reconfig is requeste while the previous one is still active). --- conf/conf.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/conf/conf.c b/conf/conf.c index 4e31de29..7ef729b3 100644 --- a/conf/conf.c +++ b/conf/conf.c @@ -197,8 +197,12 @@ cleanup: void config_free(struct config *c) { - if (c) - rfree(c->pool); + if (!c) + return; + + ASSERT(!c->obstacle_count); + + rfree(c->pool); } /** @@ -207,10 +211,14 @@ config_free(struct config *c) * This function frees the old configuration (%old_config) that is saved for the * purpose of undo. It is useful before parsing a new config when reconfig is * requested, to avoid keeping three (perhaps memory-heavy) configs together. + * Configuration is not freed when it is still active during reconfiguration. */ void config_free_old(void) { + if (!old_config || old_config->obstacle_count) + return; + tm_stop(config_timer); undo_available = 0;